[MacPorts] #39197: New port: RStudio

[MacPorts]

#39197: New port: RStudio
----------------------------+--------------------------------
  Reporter:  kjell.konis@…  |      Owner:  macports-tickets@…
      Type:  submission     |     Status:  new
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.1.3
Resolution:                 |   Keywords:
      Port:                 |
----------------------------+--------------------------------

Comment (by ryandesign@…):

 Some observations:

  * Line 2 should be "# $Id$" as usual.
  * You don't need to list "depends_build cmake"; the cmake portgroup does
 that for you.
  * Since you fetch from github, consider using the github portgroup.
  * The port appears to fetch the latest version from the git repository.
 It must instead fetch a specific commit that you've tested, so that the
 process is repeatable. Even better would be to fetch a git tag instead,
 which is what the github portgroup does by default. Perhaps "v0.98.133"
 which was created yesterday. Naturally your version number would change as
 well. So with the github portgroup, this would be "github.setup rstudio
 rstudio 0.98.133 v", and then remove the fetch.type and git.url, and add
 checksums.
  * Instead of "system 'cd … && …'" you should use "system -W … '…'"
  * I don't like the script that downloads and installs additional
 dependencies in post-extract, but I don't suppose I'd like it any better
 anywhere else either. One slight improvement might be if the scripts were
 patched to not download any files, and to instead list the files to be
 downloaded in the Portfile as usual with checksums.
  * The last line of the script is "sudo cp /etc/pam.d/ftpd
 /etc/pam.d/rstudio". Certainly MacPorts does not permit ports to touch
 files outside of ${workpath} except in the activate and deactivate phases.
 If MacPorts doesn't interrupt the install at this point, it will at least
 prevent action from having happened. So if this action is important to the
 port, you'll have to perform it in a post-activate block. However I would
 hope a port wouldn't put files in /etc; ${prefix}/etc would be more
 appropriate.

-- 
Ticket URL: <https://trac.macports.org/ticket/39197#comment:1>
MacPorts <http://www.macports.org/>
Ports system for OS X