[MacPorts] #40831: PortGroup github 1.0 shouldn't set name in subport

[MacPorts]

#40831: PortGroup github 1.0 shouldn't set name in subport
------------------------------+--------------------------------
  Reporter:  davide.liessi@…  |      Owner:  macports-tickets@…
      Type:  defect           |     Status:  new
  Priority:  Normal           |  Milestone:
 Component:  ports            |    Version:  2.2.99
Resolution:                   |   Keywords:  github PortGroup
      Port:  github           |
------------------------------+--------------------------------

Comment (by davide.liessi@…):

 Replying to [comment:5 raimue@…]:
 > In my opinion `PortInfo` is an internal data structure and should not be
 used by Portfiles. Can't we check if we are in a subport with `$subport !=
 $name` as we already do in other Portfiles?

 I did try many things that I saw in other Portfiles, including this, but
 they either didn't work or gave errors with `port lint`.
 In this case, I wasn't able to access `name` from the PortGroup file when
 github.setup is used inside a subport.

 Replying to [comment:6 ryandesign@…]:
 > Why does this need to be any more complicated than changing
 > {{{
 > name                ${github.project}
 > }}}
 > to
 > {{{
 > default name        {${github.project}}
 > }}}
 > ?

 This seems to work.
 Are the external `{}` really necessary?
 I can't see any difference here.

-- 
Ticket URL: <https://trac.macports.org/ticket/40831#comment:7>
MacPorts <http://www.macports.org/>
Ports system for OS X