[MacPorts] #29548: hugin-app: hardcodes prefix and applications_dir

[MacPorts]

#29548: hugin-app: hardcodes prefix and applications_dir
---------------------------+--------------------------------
  Reporter:  ryandesign@…  |      Owner:  macports-tickets@…
      Type:  defect        |     Status:  closed
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:  1.9.2
Resolution:  fixed         |   Keywords:
      Port:  hugin-app     |
---------------------------+--------------------------------
Changes (by ryandesign@…):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:1 hvdwolf@…]:
 > I do not exactly understand what you mean. The relevant part in the
 CMakeLists.txt file is:
 >
 > {{{
 >     IF (CMAKE_INSTALL_PREFIX STREQUAL "/opt/local")
 >       # MacPorts
 >       SET(INSTALL_OSX_BUNDLE_DIR /Applications/MacPorts CACHE DOCSTRING
 "Install directory Hugin and HuginStitchProject application bundles")
 >     ELSE(CMAKE_INSTALL_PREFIX STREQUAL "/opt/local")
 >       # fink or other custom system.
 >       SET(INSTALL_OSX_BUNDLE_DIR ${CMAKE_INSTALL_PREFIX}/Applications
 CACHE DOCSTRING "Install directory Hugin and HuginStitchProject
 application bundles")
 >     ENDIF(CMAKE_INSTALL_PREFIX STREQUAL "/opt/local")
 > }}}

 This says: if ${prefix} is /opt/local, then install the application to
 /Applications/MacPorts, otherwise install it to ${prefix}/Applications.
 That's not what we want. We always want to install the application to
 ${applications_dir}. The default for ${applications_dir} happens to be
 /Applications/MacPorts, but the user might have changed it. Fixed in
 r114003.

 > Other files that possibly seem to hardcode /opt and /sw are the cmake
 macros FIND<whatever>. In these files also /usr, /usr/local, etcetera are
 hardcoded to make cmake find libraries/frameworks at places other than the
 system paths.
 > If this hardcoded paths are also in other parts, please let me know.

 That would be a problem, but they seem to only check those hardcoded paths
 if pkgconfig is not found, but hugin-app does depend on pkgconfig so this
 should be fine.

-- 
Ticket URL: <https://trac.macports.org/ticket/29548#comment:3>
MacPorts <http://www.macports.org/>
Ports system for OS X