[MacPorts] #40831: PortGroup github 1.0 shouldn't set name in subport

[MacPorts]

#40831: PortGroup github 1.0 shouldn't set name in subport
------------------------------+--------------------------------
 Reporter:  davide.liessi@…   |      Owner:  macports-tickets@…
     Type:  defect            |     Status:  new
 Priority:  Normal            |  Milestone:
Component:  ports             |    Version:  2.2.99
 Keywords:  github PortGroup  |       Port:  github
------------------------------+--------------------------------
 {{{github.setup}}} sets the port name to the project name (among other
 things).[[BR]]
 This causes troubles if the instruction is used inside a subport, namely
 the subport is not found by 'port'.

 Setting {{{name ${subport}}}} after {{{github.setup}}} causes an error
 with 'port lint' (port name and directory name mismatch).[[BR]]
 A workaround is {{{set PortInfo(name) ${subport}}}} (see also the
 definition of 'proc subport' in portutil.tcl).

 The solution would be to conditionally set {{{name}}} only when
 {{{github.setup}}} is not used in a subport, since the subport name is
 already set.

 An example where this problem arises can be seen in
 attachment:Portfile.9:ticket:40139.

 (Cc: ryandesign because he's the one who created the PortGroup and did
 most of the changes.)

-- 
Ticket URL: <https://trac.macports.org/ticket/40831>
MacPorts <http://www.macports.org/>
Ports system for OS X