[MacPorts] #40631: blockout2 @2.4_0

MacPorts noreply at macports.org
Mon Sep 30 02:14:25 PDT 2013


#40631: blockout2 @2.4_0
-------------------------+--------------------------------
  Reporter:  jeremy@…    |      Owner:  macports-tickets@…
      Type:  submission  |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.2.0
Resolution:              |   Keywords:
      Port:              |
-------------------------+--------------------------------

Comment (by ryandesign@…):

 Thanks. Some initial observations:

  * The portfile uses a mixture of tabs and spaces. Portfiles should use
 only spaces, as the modeline states.
  * The distfile name doesn't contain the version number, so the
 dist_subdir should; see wiki:PortfileRecipes#unversioned-distfiles
  * I'm worried about the post-extract phase which replaces the Makefile.
 Could the Makefile be patched instead?
  * The app.executable line could be simplified by using the ${worksrcpath}
 variable instead of ${workpath}
  * The declared universal variant doesn't do anything.

-- 
Ticket URL: <https://trac.macports.org/ticket/40631#comment:1>
MacPorts <http://www.macports.org/>
Ports system for OS X


More information about the macports-tickets mailing list