[MacPorts] #43204: Change BZIP2 variable name for configure script

[MacPorts]

#43204: Change BZIP2 variable name for configure script
-------------------------+--------------------------------
  Reporter:  eborisch@…  |      Owner:  macports-tickets@…
      Type:  defect      |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  base        |    Version:  2.2.1
Resolution:              |   Keywords:
      Port:              |
-------------------------+--------------------------------

Comment (by eborisch@…):

 Most applications (wild speculation; haven't run into others, I'm sure
 there are some out there) don't use an environment variable sharing their
 name as an argument.

 Perhaps this tweak aclocal.m4 is lower impact:

 {{{#!diff
 Index: aclocal.m4
 ===================================================================
 --- aclocal.m4  (revision 118652)
 +++ aclocal.m4  (working copy)
 @@ -138,7 +138,11 @@
                                 AC_MSG_ERROR([Don't know how to extract
 tarball $mp_tarball])
                                 ;;
                 esac
 +    # bzip2 uses the BZIP2 environment variable as an argument. Clear it
 out during execution.
 +    BZIP2_SAVE=$BZIP2
 +    BZIP2=
                 (cd "$mp_tarball_vendordir"; "$mp_tarball_extract_cmd" -d
 < "$ac_abs_confdir/$mp_tarball" | tar xf - || AC_MSG_ERROR([failed to
 extract $mp_tarball]))
 +    BZIP2=$BZIP2_SAVE
         fi
         if ! test -d "$ac_dir"; then
                 AC_MSG_ERROR([tarball $mp_tarball did not extract to
 $ac_dir])
 }}}

 The only side effect here is an extra BZIP2_SAVE variable after it has
 been evauated.

-- 
Ticket URL: <https://trac.macports.org/ticket/43204#comment:4>
MacPorts <http://www.macports.org/>
Ports system for OS X