[MacPorts] #43339: Update arb to 6.0

[MacPorts]

#43339: Update arb to 6.0
------------------------------+---------------------------------
  Reporter:  matt.cottrell@…  |      Owner:  macports-tickets@…
      Type:  update           |     Status:  new
  Priority:  Normal           |  Milestone:
 Component:  ports            |    Version:  2.2.1
Resolution:                   |   Keywords:  haspatch maintainer
      Port:  arb              |
------------------------------+---------------------------------

Comment (by ryandesign@…):

 Thanks. Some remarks about your changes:

 You've set the version field to 6.0, but it appears to actually be
 downloading version 6.0-rc1. You shouldn't deceive the user as to what
 version they're going to get. If this is 6.0-rc1, put 6.0-rc1 in the
 version field. We usually update ports to stable versions, not release
 candidates or other development releases. However if you as maintainer
 feel that 6.0-rc1 is more stable or more usable than the official latest
 stable release 5.5 then that's ok.

 You've added a dependency on `port:glib2`. You should instead write
 `path:lib/pkgconfig/glib-2.0.pc:glib2` so that glib2-devel could satisfy
 the dependency.

 You've added this block:
 {{{
                         # https://trac.macports.org/ticket/33756
                         if {${configure.compiler} == "llvm-gcc-4.2"} {
                              configure.compiler clang
                         }
 }}}

 The correct way to express this is:

 {{{
 compiler.blacklist *llvm-gcc-4.2
 }}}

 This will blacklist both the Xcode and MacPorts versions of llvm-gcc and
 will use the next best compiler, which will most likely be a version of
 clang.

 However, you should fix the ticket citation. #33756 is about clang not
 working; it says nothing about llvm-gcc-4.2 not working (quite the
 opposite, in fact).

 You added this check:

 {{{
 #Adjusting configure flags for Clang on Lion (ticket #34545)
 if {${configure.compiler} == "clang"} {
     configure.args-append   -CXX_FLAGS="-Wno-reserved-user-defined-literal
 -stdlib=libc++"
 }}}

 Note that MacPorts may select a different clang compiler, i.e. one
 provided by MacPorts rather than one from Xcode. To target any version of
 clang, you should usually use:

 {{{
 if {[string match *clang* ${configure.compiler}]} {
 }}}

 However, setting `-stdlib=libc++` is suspect. Have you read
 wiki:FAQ#libcpp? You cite #34545, but that's about kdevplatform, not arb,
 and the code in question, although it was added to kdevplatform 22 months
 ago, was subsequently changed.

-- 
Ticket URL: <https://trac.macports.org/ticket/43339#comment:1>
MacPorts <http://www.macports.org/>
Ports system for OS X