[MacPorts] #43508: vmdktool 1.3

[MacPorts]

#43508: vmdktool 1.3
-------------------------+--------------------------
  Reporter:  glenn@…     |      Owner:  ryandesign@…
      Type:  submission  |     Status:  closed
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.2.1
Resolution:  fixed       |   Keywords:
      Port:  vmdktool    |
-------------------------+--------------------------
Changes (by ryandesign@…):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 There seems to be a slightly different definition of a type that zlib is
 using between Xcode's clang and the Mavericks system headers. This isn't
 vmdktool's fault, but vmdktool's Makefile has requested that this warning,
 and all warnings, be treated as errors, by using the `-Werror` flag. We
 usually don't want to build anything in MacPorts with the `-Werror` flag,
 because newer compilers have warnings about new conditions that developers
 might not have considered before. Expanding the existing Makefile patch to
 remove `-Werror` allows the build to succeed.

 The error also shows us that vmdktool is using zlib, so it needs a
 dependency on zlib.

 As for the expand_number.c diff, I was able to build the port on Mavericks
 without it. What problem did you encounter? I'll commit it without the
 patch for now, and see if any of the buildslaves complain.

 Adding the right `-arch` flags, universal variant and compiler choice were
 easy since the Makefile respects the CC and CFLAGS environment variables.

 I added "test.run yes" since the Makefile does have a test target, and it
 does pass for me when I then run "port test".

 I also fixed the livecheck.

 Committed in r119548.

-- 
Ticket URL: <https://trac.macports.org/ticket/43508#comment:5>
MacPorts <http://www.macports.org/>
Ports system for OS X