[MacPorts] #44535: CrystFEL software suite

[MacPorts]

#44535: CrystFEL software suite
-------------------------+--------------------------------
  Reporter:  rkirian@…   |      Owner:  macports-tickets@…
      Type:  submission  |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.3.1
Resolution:              |   Keywords:
      Port:  crystfel    |
-------------------------+--------------------------------

Comment (by ryandesign@…):

 Thanks. Some observations:

  * the `license` should be "`GPL-3`" (or possibly "`GPL-3+`"; I haven't
 checked). See `port lint`:

 {{{
 $ port lint
 --->  Verifying Portfile for crystfel
 Error: invalid license 'GPLv3': missing hyphen before version
 }}}

  * the `maintainers` line must be your valid email address, in our
 obfuscated host:user format
  * the pango dependency should be written so that pango-devel could
 satisfy it; see other ports that depend on pango for an example
  * pkgconfig and gtk-doc are typically only used at build time and should
 therefore be `depends_build` not `depends_lib`
  * for better logging, `--disable-silent-rules` should be added to
 `configure.args`
  * the `post-destroot` block has numerous problems:
    * "`file copy`" can be more succinctly written as "`copy`"
    * you're attempting to copy files directly into `${prefix}`, bypassing
 `${destroot}`; MacPorts sandboxing prevents this from succeeding; this
 ''should'' cause a permission denied error to be printed and the destroot
 phase to be interrupted at that point, but that's not happening; I don't
 understand why
    * if you fix that, then on the preceding line you're pre-creating the
 directory, which should cause the `copy` to exit with an error that the
 directory already exists
    * the Makefile already installs these files in
 ${prefix}/share/doc/crystfel/scripts; you could `move` them into
 ${prefix}/share/examples/crystfel to better conform to `portheir(7)`.

-- 
Ticket URL: <https://trac.macports.org/ticket/44535#comment:1>
MacPorts <http://www.macports.org/>
Ports system for OS X