[MacPorts] #46029: port submission: qtchooser

[MacPorts]

#46029: port submission: qtchooser
--------------------------+--------------------------------
  Reporter:  rjvbertin@…  |      Owner:  macports-tickets@…
      Type:  submission   |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:  2.3.3
Resolution:               |   Keywords:
      Port:  qtchooser    |
--------------------------+--------------------------------

Comment (by larryv@…):

 Replying to [comment:10 rjvbertin@…]:
 > While I can agree that it's less unorthodox to do the patching in
 > a patch phase, I don't agree with the principle of using a patchfile
 > and then re-patching on top of that. Not for simple changes like this.

 They’re simple until the files change out from under you and your
 substitutions mysteriously stop working or start doing the wrong thing.
 And you’ll be confident that this won’t ever happen to //you//, until it
 does.

 This isn’t just dogma; we do it this way from experience. With a patch,
 it’s obvious when the file has changed — the patch applies with an offset
 or fuzz. If the file changes too much, the patch fails to apply. It’s a
 little more work but much better practice.

-- 
Ticket URL: <https://trac.macports.org/ticket/46029#comment:11>
MacPorts <https://www.macports.org/>
Ports system for OS X