[MacPorts] #41989: gnuplot +pangocairo does not need pdflib

[MacPorts]

#41989: gnuplot +pangocairo does not need pdflib
----------------------------+----------------------
  Reporter:  kingcrimson@…  |      Owner:  mojca@…
      Type:  enhancement    |     Status:  reopened
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:
Resolution:                 |   Keywords:
      Port:  gnuplot        |
----------------------------+----------------------

Comment (by kingcrimson@…):

 Replying to [comment:6 mojca@…]:
 > Actually, I just realized that the patch is a tiny bit wrong. If
 `pdflib` is present, `gnuplot` still links against it unless one provides
 an explicit configure flag `--without-pdf`. At least that is what happens
 here.
 >
 > It is true though that if `pdflib` is absent or disabled, `set term pdf`
 switches to `pdfcairo` automatically. The real question now is whether
 anyone really needs `pdflib` when `pdfcairo` terminal is present.


 Even though I don't think it makes sense for anyone to use pdflib when
 pangocairo is enabled, as gnuplot allows this configuration maybe it
 makes sense that the port make it possible too.

 This patch should add an additional variant named pdflib which allows
 to select pdflib to handle the pdf terminal if someone really wants to.


 {{{
 @@ -47,7 +47,6 @@
                              port:fontconfig \
                              port:gd2 \
                              port:jpeg \
 -                            port:pdflib \
                              port:libiconv \
                              port:libpng \
                              port:ncurses \
 @@ -60,7 +59,6 @@

  configure.args              --with-readline=${prefix} \
                              --with-gd=${prefix} \
 -                            --with-pdf=${prefix} \
                              --with-png=${prefix} \
                              --without-aquaterm \
                              --without-x \
 @@ -74,7 +72,8 @@
                              --without-latex \
                              --without-tutorial \
                              --without-cairo \
 -                            --without-lua
 +                            --without-lua \
 +                            --without-pdf

  variant aquaterm description "Enable AquaTerm terminal" {
      depends_lib-append      port:aquaterm
 @@ -106,6 +105,12 @@
      configure.args-delete   --without-cairo
  }

 +variant pdflib description "Enable pdflib-based pdf terminal" {
 +    depends_lib-append      port:pdflib
 +    configure.args-delete   --without-pdf
 +    configure.args-append   --with-pdf=${prefix}
 +}
 +
  variant wxwidgets description "Enable wxt terminal" {
      wxWidgets.use           wxWidgets-3.0
      depends_lib-append      port:${wxWidgets.port}
 path:lib/pkgconfig/pango.pc:pango
 }}}

 does this look OK to you?

-- 
Ticket URL: <https://trac.macports.org/ticket/41989#comment:8>
MacPorts <http://www.macports.org/>
Ports system for OS X