[MacPorts] #42872: cmake PortGroup: don't add -I${prefix}/include to CXXFLAGS

MacPorts noreply at macports.org
Tue Jun 17 12:53:55 PDT 2014


#42872: cmake PortGroup: don't add -I${prefix}/include to CXXFLAGS
----------------------+--------------------------------
  Reporter:  mojca@…  |      Owner:  macports-tickets@…
      Type:  defect   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:           |
----------------------+--------------------------------

Comment (by mojca@…):

 Is the following OK?
 {{{
 #!diff
 --- cmake-1.0.tcl       (revision 121111)
 +++ cmake-1.0.tcl       (working copy)
 @@ -81,12 +81,9 @@
      # The environment variable CPPFLAGS is not considered by CMake.
      # (CMake upstream ticket #12928 "CMake silently ignores CPPFLAGS"
      # <http://www.cmake.org/Bug/view.php?id=12928>).
 -    # Thus, we have to add them manually to the CFLAGS and CXXFLAGS in
 the
 -    # pre-configure phase.
 -    if {${configure.cppflags} ne ""} {
 -        configure.cflags-append ${configure.cppflags}
 -        configure.cxxflags-append ${configure.cppflags}
 -    }
 +    #
 +    # But adding -I${prefix}/include to CFLAGS/CXXFLAGS is a bad idea.
 +    # If any other flags are needed, we need to add them.

      # In addition, CMake provides build-type-specific flags for
      # Release (-O3 -DNDEBUG), Debug (-g), MinSizeRel (-Os -DNDEBUG), and
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/42872#comment:17>
MacPorts <http://www.macports.org/>
Ports system for OS X


More information about the macports-tickets mailing list