[MacPorts] #44197: launch4j: update to 3.4 and tidy portfile

[MacPorts]

#44197: launch4j: update to 3.4 and tidy portfile
------------------------------+--------------------------------
 Reporter:  steve+macports@…  |      Owner:  macports-tickets@…
     Type:  update            |     Status:  new
 Priority:  Normal            |  Milestone:
Component:  ports             |    Version:  2.3.1
 Keywords:                    |       Port:  launch4j
------------------------------+--------------------------------
 launch4j is now at version 3.4 upstream.

 I'm attaching a proposed Portfile that includes these changes:
 1. Tidy up
  1. Normalise whitespace - replace tabs with spaces.
  1. Use absolute instead of relative path for symlink to executable.
 Looking through my /opt/local/bin, this seems to be the convention in
 MacPorts.
  1. Reorganise modifications to extracted files and add comments.  First
 delete the various groups of unwanted files, then move the documentation
 into place, then install the program files.
  1. Add license info.
 1. Update to version 3.4
  1. Update version and distname, replace checksums with types advised in
 guide.
  1. Delete / move newly added files in distribution.
  1. Remove patchfile and instead use reinplace to set the absolute path to
 launch4j.jar in launch4j script.  The upstream script looks for the jar in
 the same directory as the script, which won't work when the script is
 executed via a link.  The patchfile (which no longer works against version
 3.4) fixed this for the symlink, but broke the real script.  An
 alternative is to use a wrapper script (that just execs the real script)
 instead of a symlink, as used by clang-3.x for example.

 I'm new here, so I'd appreciate some guidance on whether to provide one
 big diff, or break my changes up into several patches and attach them
 here, or to split some of this off into a separate ticket.  Cheers.

-- 
Ticket URL: <https://trac.macports.org/ticket/44197>
MacPorts <http://www.macports.org/>
Ports system for OS X