[MacPorts] #42692: [NEW] grr

[MacPorts]

#42692: [NEW] grr
-------------------------+--------------------------------
  Reporter:  jul_bsd@…   |      Owner:  macports-tickets@…
      Type:  submission  |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.2.1
Resolution:              |   Keywords:
      Port:  grr         |
-------------------------+--------------------------------

Comment (by ryandesign@…):

 Thanks. Some observations:

  * The version line should be the only place where you hardcode the
 version number. Anywhere else that you need to refer to the version
 number, such as in this port in the git.branch line, you should use the
 ${version} variable.
  * Since you're fetching from git, there's no reason to have the distname
 or master_sites lines.
  * It's unusual that you're doing a bunch of reinplaces in post-extract.
 Usually you want the extract phase to end with a more or less pristine
 copy of the source code, and then in the patch phase you can modify it as
 needed prior to building.
  * The two extra files you attached have "/opt/local" hardcoded. Usually
 you would write the files with a placeholder such as "@PREFIX@" and then
 have a post-patch reinplace in the portfile to change the placeholder to
 ${prefix}.
  * Instead of manually creating ".turf" files in directories, presumably
 to keep them from being deleted, use
 [https://guide.macports.org/chunked/reference.phases.html#reference.phases.destroot
 destroot.keepdirs].

-- 
Ticket URL: <https://trac.macports.org/ticket/42692#comment:1>
MacPorts <http://www.macports.org/>
Ports system for OS X