[MacPorts] #36179: Please add port select --summary option
MacPorts
noreply at macports.org
Mon Mar 3 15:48:32 PST 2014
#36179: Please add port select --summary option
-------------------------------+--------------------------------
Reporter: Deil.Christoph@… | Owner: macports-tickets@…
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: base | Version: 2.1.2
Resolution: | Keywords:
Port: |
-------------------------------+--------------------------------
Comment (by cal@…):
Looks good at first sight – unfortunately I can't test right now because
my working copy is busy tracking other changes and I don't want to risk
mix them (why don't we use git again? :/).
One thing I noticed is that your changes put `set group [lindex $portlist
0]` before the length check of `$portlist`. Since `lindex` doesn't fail on
invalid indices that's not a problem per-se, I just think it would be a
little cleaner to move it after the check.
The indentation seems to be a little off in some places, too, but that's
just a cosmetic issue.
Everything else seems to be in order – what's the problem with testing it?
Don't have any select-capable ports installed? You can just install
`python_select` or `mysql_select` – they won't have anything to select,
but they should still show up just fine in your summary output.
--
Ticket URL: <https://trac.macports.org/ticket/36179#comment:6>
MacPorts <http://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list