[MacPorts] #42767: Commit email shows property changes incorrectly

[MacPorts]

#42767: Commit email shows property changes incorrectly
----------------------------+-------------------------
 Reporter:  ryandesign@…    |      Owner:  wsiegrist@…
     Type:  defect          |     Status:  new
 Priority:  Normal          |  Milestone:
Component:  server/hosting  |    Version:
 Keywords:                  |       Port:
----------------------------+-------------------------
 r117622 changed the svn:ignore property of the directory
 [browser:trunk/base/src/macports1.0 at 117622 trunk/base/src/macports1.0] as
 follows:

 {{{
 Index: trunk/base/src/macports1.0
 ===================================================================
 --- trunk/base/src/macports1.0  (revision 117621)
 +++ trunk/base/src/macports1.0  (revision 117622)

 Property changes on: trunk/base/src/macports1.0
 ___________________________________________________________________
 Modified: svn:ignore
 ## -1,5 +1,6 ##
  *.dylib
 +Makefile
  macports_autoconf.tcl
 +macports_fastload.tcl
  macports_test_autoconf.tcl
 -macports_fastload.tcl
  pkgIndex.tcl
 }}}

 This is how `svn diff` shows it. Trac shows it similarly. In
 [https://lists.macosforge.org/pipermail/macports-
 changes/2014-March/102406.html the commit email], however, it's shown less
 well. The text part of the email shows it like this:

 {{{
 Property changes on: trunk/base/src/macports1.0
 ___________________________________________________________________
 Modified: svn:ignore
    - *.dylib
 macports_autoconf.tcl
 macports_test_autoconf.tcl
 macports_fastload.tcl
 pkgIndex.tcl

    + *.dylib
 Makefile
 macports_autoconf.tcl
 macports_fastload.tcl
 macports_test_autoconf.tcl
 pkgIndex.tcl
 }}}

 This is unnecessarily convoluted but is at least accurate. The HTML part,
 however, which is what most viewers will see in their email readers, is
 completely wrong:

 {{{
 <div id=3D"patch">
 <h3>Diff</h3>
 <a id=3D"trunkbasesrcmacports10"></a>
 <div class=3D"propset"><h4>Property changes: trunk/base/src/macports1.0</=
 h4>
 <pre class=3D"diff"><span>
 </span></pre></div>
 <a id=3D"svnignore"></a>
 <div class=3D"modfile"><h4>Modified: svn:ignore</h4></div>
 <span class=3D"cx">macports_autoconf.tcl
 </span><span class=3D"cx">macports_test_autoconf.tcl
 </span><span class=3D"cx">macports_fastload.tcl
 </span><span class=3D"cx">pkgIndex.tcl
 </span><span class=3D"cx">   + *.dylib
 </span><span class=3D"cx">Makefile
 </span><span class=3D"cx">macports_autoconf.tcl
 </span><span class=3D"cx">macports_fastload.tcl
 </span><span class=3D"cx">macports_test_autoconf.tcl
 </span><span class=3D"cx">pkgIndex.tcl
 </span>
 }}}

 Note how it's an encoding of the text version, but with the first line ("`
 - *.dylib`") omitted, thereby making it unintelligible.

 Is Mac OS Forge doing this deliberately, or is this just the behavior of
 the [http://search.cpan.org/~dwheeler/SVN-Notify/ SVN::Notify] script
 we're using to send emails? If the latter, are we using the latest version
 of SVN::Notify, 2.84? If not, could we update to that version to see if
 that helps?

-- 
Ticket URL: <https://trac.macports.org/ticket/42767>
MacPorts <http://www.macports.org/>
Ports system for OS X