[MacPorts] #42949: elvis crash on Mavericks

[MacPorts]

#42949: elvis crash on Mavericks
-----------------------+---------------------------------
  Reporter:  crosma@…  |      Owner:  macports-tickets@…
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:  2.2.1
Resolution:            |   Keywords:  haspatch maintainer
      Port:  elvis     |
-----------------------+---------------------------------
Changes (by ryandesign@…):

 * cc: ryandesign@… (added)


Comment:

 I agree with the maintainer: since the project's non-autoconf Makefile
 already puts the optimization flag into CC, that's where we should put it.
 It also stuffs other CFLAGS and CPPFLAGS into CC. I'm not comfortable
 setting CFLAGS in the portfile to a value ("`-I. -Iosunix -O2`") that
 contains intimate knowledge of the build system and could change with
 future versions of the software, although there hasn't been a new version
 in over 10 years, so maybe that's a moot point.

 The default value of CC for this build system is "`cc -O`". MacPorts base
 overrides this to be ${configure.cc}, in other words specifying no
 optimization flag, which apparently results in the crash. The suggestion
 is now to use "`-O2`" as the optimization flag. Is there a reason why we
 don't want to use the MacPorts default optimization flag value of "`-Os`"?

 Since this is a runtime crash, not a build failure, the port's revision
 needs to be increased to rebuild the port.

 The port is not using `-arch` flags nor does it have a universal variant.
 This would be an opportunity to fix that as well.

 See my attached patch which works for me and addresses all of the above.

-- 
Ticket URL: <https://trac.macports.org/ticket/42949#comment:4>
MacPorts <http://www.macports.org/>
Ports system for OS X