[MacPorts] #43564: girara @0.2.0

[MacPorts]

#43564: girara @0.2.0
--------------------------+--------------------------------
  Reporter:  starkhalo@…  |      Owner:  macports-tickets@…
      Type:  submission   |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:  2.2.1
Resolution:               |   Keywords:
      Port:  girara       |
--------------------------+--------------------------------
Changes (by ryandesign@…):

 * keywords:  pwmt =>


Comment:

 Thanks. Some observations:

  * There should be a blank line between the "`# $Id$`" line and the
 "`PortSystem 1.0`" line.
  * The license field should just be "`zlib`" (not "`zlib License`").
  * The homepage variable could be used in the definition of master_sites.
  * The line "`distname girara-${version}`" should be removed because that
 is the default.
  * The checksums for the patchfiles should be removed because checksums
 are not used for local patchfiles.
  * The distname should be removed from the checksums line because there is
 only one file being checksummed.
  * Because you use "`use_configure no`" you should add code to ensure
 you're UsingTheRightCompiler, use the right `-arch` flags, and add a
 universal variant if possible.
  * The dependency on glib2 should be written so that glib2-devel could
 satisfy it.
  * The patchfile names should be of the form "patch-*.diff".

 In patch-Makefile:

  * The install_name is usually set with "`-install_name`"; if there is no
 special reason why you instead used "`-Wl,-dylib_install_name,`", it
 should be changed (in both places)
  * Have you reported the OS X compatibility issues that necessitated
 writing this patch to the developers of girara so that they can fix the
 build system so that these patches are no longer needed in the future? If
 so please let us know the URL of the bug report, mailing list post, etc.

-- 
Ticket URL: <https://trac.macports.org/ticket/43564#comment:1>
MacPorts <http://www.macports.org/>
Ports system for OS X