[MacPorts] #44846: icu @53.1_1 __PREFIX__ not replaced after patch

[MacPorts]

#44846: icu @53.1_1 __PREFIX__ not replaced after patch
----------------------+--------------------------------
 Reporter:  zan@…     |      Owner:  macports-tickets@…
     Type:  defect    |     Status:  new
 Priority:  Normal    |  Milestone:
Component:  ports     |    Version:  2.3.1
 Keywords:  haspatch  |       Port:  icu
----------------------+--------------------------------
 Upgrading icu to version 53.1_1 completes without error, but after
 activation MacPorts scans the installed binaries for link errors and the
 following error shows:

 {{{
 --->  Updating database of binaries
 --->  Scanning binaries for linking errors
 Could not open __PREFIX__/lib/libicudata.53.dylib: Error opening or
 reading file (referenced from /opt/local/bin/derb)
 Could not open __PREFIX__/lib/libicuuc.53.dylib: Error opening or reading
 file (referenced from /opt/local/bin/derb)
 Could not open __PREFIX__/lib/libicui18n.53.dylib: Error opening or
 reading file (referenced from /opt/local/bin/derb)
 Could not open __PREFIX__/lib/libicutu.53.dylib: Error opening or reading
 file (referenced from /opt/local/bin/derb)
 Could not open __PREFIX__/lib/libicuio.53.dylib: Error opening or reading
 file (referenced from /opt/local/bin/derb)
 Could not open __PREFIX__/lib/libicule.53.dylib: Error opening or reading
 file (referenced from /opt/local/lib/libiculx.53.1.dylib)
 --->  Found 85 broken file(s), matching files to ports
 --->  Found 1 broken port(s):
      icu @53.1 -doc
          /opt/local/bin/derb
          /opt/local/bin/genbrk
          /opt/local/bin/gencfu
          /opt/local/bin/gencnval
          /opt/local/bin/gendict
          /opt/local/bin/genrb
          /opt/local/bin/icuinfo
          /opt/local/bin/makeconv
          /opt/local/bin/pkgdata
          /opt/local/bin/uconv
          /opt/local/lib/libicui18n.53.1.dylib
          /opt/local/lib/libicuio.53.1.dylib
          /opt/local/lib/libicule.53.1.dylib
          /opt/local/lib/libiculx.53.1.dylib
          /opt/local/lib/libicutest.53.1.dylib
          /opt/local/lib/libicutu.53.1.dylib
          /opt/local/lib/libicuuc.53.1.dylib
          /opt/local/sbin/genccode
          /opt/local/sbin/gencmn
          /opt/local/sbin/gennorm2
          /opt/local/sbin/gensprep
          /opt/local/sbin/icupkg
 }}}

 Solution: the {{{__PREFIX__}}} inserted by patch-config-mh-darwin.diff
 needs to be replaced with {{{${prefix} }}} by a post-patch reinplace.
 Portfile patch attached.

-- 
Ticket URL: <https://trac.macports.org/ticket/44846>
MacPorts <http://www.macports.org/>
Ports system for OS X