[MacPorts] #44882: [developer] kdelibs4 4.14/git/master portfile and directory

[MacPorts]

#44882: [developer] kdelibs4 4.14/git/master portfile and directory
--------------------------+--------------------------------
  Reporter:  rjvbertin@…  |      Owner:  macports-tickets@…
      Type:  enhancement  |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch
      Port:  kdelibs4     |
--------------------------+--------------------------------

Comment (by larryv@…):

 Other comments:
 - It’s not acceptable for `revision` to be a date. The point of `revision`
 is to represent the versioning of the Portfile, not of the packaged
 software. If you want to incorporate the date into the version, you’d do
 something like
   {{{
 version 4.14.0-20140902
   }}}
 - `master_sites` is not used if `fetch.type` is “git”.
 - You use this idiom frequently:
   {{{
 variant FOO {}
 if {[variant_isset FOO]} { do some stuff }
   }}}
   Why not just put the stuff inside the variant block? That’s our
 convention.
 - There’s no reason to check whether `startupitem.install` is available.
 The released version of MacPorts has it, so all Portfiles should just
 assume it’s there.

-- 
Ticket URL: <https://trac.macports.org/ticket/44882#comment:5>
MacPorts <http://www.macports.org/>
Ports system for OS X