[MacPorts] #45091: Adding HHVM Portfile

MacPorts noreply at macports.org
Fri Sep 19 17:23:06 PDT 2014


#45091: Adding HHVM Portfile
-------------------------------+--------------------------------
  Reporter:  cornelius.howl@…  |      Owner:  macports-tickets@…
      Type:  submission        |     Status:  new
  Priority:  Normal            |  Milestone:
 Component:  ports             |    Version:  2.3.1
Resolution:                    |   Keywords:
      Port:  hhvm              |
-------------------------------+--------------------------------

Comment (by ryandesign@…):

 Some remarks:

  * The maintainers line must be your valid email address in our obfuscated
 host:user format.
  * A build dependency on cmake should not be added since the cmake
 portgroup already does so
  * The text you have written in the description field would make a good
 long description, if you remove the URL (set that in the homepage variable
 instead). Write a shorter description.
  * Since this software is hosted at github, the github portgroup should be
 used.
  * Fetching from master (which you do in the hhvm-devel subport) is not
 permitted. All ports must use specific upstream versions, tags, or
 commits.
  * Why has the compiler been set to macports-gcc-4.8? Usually that is not
 desired.
  * I see mysql55 is being used. There should be variants for each version
 of MySQL offered by MacPorts (mysql51, mysql55, mysql56, percona, mariadb,
 mariadb-10.0, mariadb-10.1)
  * I see lots of specific library version numbers mentioned in the
 configure.args; that should be avoided.
  * I'm surprised at the invocation of `install_name_tool` in the pre-
 destroot block; I did not know that we have a Tcl wrapper around that
 system command. Ideally, fix the cmake files so that manually editing the
 install_name later is not necessary.

-- 
Ticket URL: <https://trac.macports.org/ticket/45091#comment:2>
MacPorts <http://www.macports.org/>
Ports system for OS X


More information about the macports-tickets mailing list