[MacPorts] #40782: wireshark-devel: update to 1.11.0
MacPorts
noreply at macports.org
Mon Aug 10 10:10:56 PDT 2015
#40782: wireshark-devel: update to 1.11.0
------------------------------+-----------------------
Reporter: ryandesign@… | Owner: hsivank@…
Type: update | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords:
Port: wireshark-devel |
------------------------------+-----------------------
Comment (by hsivank@…):
Replying to [comment:30 mojca@…]:
> * `checksums`: you should use `rmd160` and `sha256`. You may remove
`md5` and `sha1`.
I would prefer *official* wireshark hash (md5,sha1,ripemd160) :
https://www.wireshark.org/download/src/all-versions/SIGNATURES-1.99.8.txt
> * `depends_build`: use `depends_build-append` instead and remove
dependency on `cmake`.
fixed
> * `configure.args`: use `configure.args-append` unless you have to
overwrite all settings set by the cmake group.
fixed
> * you should not use `default_variants +qt5`; you should first check
that the user did not set `+qt4` (ask if you need advice on coding that,
there are plenty examples in other ports, but basically you just need to
remove the variant and put it in the "`if {![variant_isset qt4] &&
![variant_isset qt5]} {`" block); or rather, you should also check that
the user did not specify `+gtk3` before enabling `qt5` (if you plan to
keep support for gtk3 and if you want the variants to conflict)
{{{
default_variants +portaudio +zlib +lua +libsmi +gnutls +libgcrypt +cares
+geoip
if {![variant_isset qt4] && ![variant_isset qt5] && ![variant_isset gtk2]
&& ![variant_isset gtk3] && ![variant_isset no_gui]} {
default_variants +qt5
}
}}}
Is it correct ?
> * enable things like lua and zlib by default
Maybe i'm missing something but zlib and lua are already enabled by
default
{{{
default_variants ... +zlib +lua ...
}}}
--
Ticket URL: <https://trac.macports.org/ticket/40782#comment:31>
MacPorts <https://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list