[MacPorts] #43466: textmate2 @2.0-alpha.9537 configure error - "Unknown signee" while downloading TextMate Bundles

[MacPorts]

#43466: textmate2 @2.0-alpha.9537 configure error - "Unknown signee" while
downloading TextMate Bundles
-------------------------------+--------------------
  Reporter:  david.hislop.1@…  |      Owner:  cal@…
      Type:  defect            |     Status:  closed
  Priority:  Normal            |  Milestone:
 Component:  ports             |    Version:  2.2.1
Resolution:  fixed             |   Keywords:
      Port:  textmate2         |
-------------------------------+--------------------
Changes (by ryandesign@…):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:3 david.hislop.1@…]:
 > In file key_chain.cc, the line {{{if(err = SecItemImport(data, NULL,
 &type, &format, 0, &params, NULL, &items) == errSecSuccess)}}} causes
 variable {{{err}}} to be set to the result of the logical expression,
 whereas the intent is to set it to the return value of
 {{{SecItemImport}}}. Needs either parentheses or splitting into an
 assignment and an {{{if()}}}. I chose the latter as in the diff output
 below.
 >
 > Also, the
 [https://developer.apple.com/library/mac/documentation/security/Reference/keychainservices/Reference/reference.html#//apple_ref/doc/uid/TP30000898
 -CH1g-SW49 documentation for SecItemImport] shows that the sequence of
 parameters {{{&type}}} and {{{&format}}} is wrong. I reversed them.

 Looks like the developer made these changes upstream:
 https://github.com/textmate/textmate/commit/6be2935518a2fd6c353886c4eedbefc76a92856b
 #diff-c1bf0f7671e17004d9138c38fcb4465f

 > These changes didn't fix the problem but at least showed that
 SecItemImport was returning {{{errSecAddinLoadFailed}}}. On a hunch, I
 changed both {{{&type}}} and {{{&format}}} to pass the "unknown" enum and
 that fixed the problem.

 The developer has not made these changes. If you're still having problems
 installing the latest version of textmate2 in MacPorts, please let us and
 the developer of textmate2 know.

-- 
Ticket URL: <https://trac.macports.org/ticket/43466#comment:4>
MacPorts <https://www.macports.org/>
Ports system for OS X