[MacPorts] #29658: phpstylist should use MacPorts PHP

[MacPorts]

#29658: phpstylist should use MacPorts PHP
--------------------------+---------------------------------
  Reporter:  face@…       |      Owner:  rudloff@…
      Type:  enhancement  |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch maintainer
      Port:  phpstylist   |
--------------------------+---------------------------------

Old description:

> phpstylist uses the Mac OS X version of PHP
>
> The patch file (see Revision 79013, 314 bytes (checked in by
> ryandesign@…, 30 hours ago)
> adds
>
> {{{#!/usr/bin/php}}}  [[BR]]
>

> to the code. Wouldn't it be more in keeping with MacPorts to make that
>
> {{{#!/usr/bin/env php}}}

New description:

 phpstylist uses the Mac OS X version of PHP

 The patch file (see Revision 79013, 314 bytes (checked in by ryandesign@…,
 30 hours ago)
 adds

 {{{
 #!/usr/bin/php
 }}}

 to the code. Wouldn't it be more in keeping with MacPorts to make that

 {{{
 #!/usr/bin/env php
 }}}

--

Comment (by ryandesign@…):

 Replying to [comment:7 rudloff@…]:
 > Here is a patch that adds php as a dependency and changes the shebang.

 Does making this change fix some problem? Does using the OS X version of
 php no longer work, for example because newer versions of OS X include
 newer versions of php?

 Since your proposed patch changes the files the port installs, the port's
 revision must be increased.

 The patch is not correct: it adds a port:php52 dependency and changes the
 shebang line to "#!/usr/bin/env php", but the php52 port does not provide
 a program called php; it provides a program called php52. (This has
 changed in the years since this ticket was filed.) If you're declaring a
 hard dependency on the php52 port, then you should make sure the program
 installed by the php52 port is the one that gets used, by making the
 shebang line "#!${prefix}/bin/php52".

 php52 is end of life, as is php53. If phpstylist will work with later
 versions of php, those should be used instead. But if not—if the whole
 purpose of this change is to prevent newer incompatible versions of php
 from being used by this 8-year-old software—then using php52 is fine.

-- 
Ticket URL: <https://trac.macports.org/ticket/29658#comment:9>
MacPorts <https://www.macports.org/>
Ports system for OS X