[MacPorts] #50121: submission: chrony NTP server
MacPorts
noreply at macports.org
Wed Dec 23 10:13:55 PST 2015
#50121: submission: chrony NTP server
-------------------------+--------------------------------
Reporter: florian@… | Owner: macports-tickets@…
Type: submission | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords:
Port: chrony |
-------------------------+--------------------------------
Comment (by ryandesign@…):
Thanks. Some comments:
* The `$Id$` line should be `$Id$`, not `$Id:$`.
* There should be a blank line after the `PortSystem 1.0` line.
* The `system` invocation in your post-build block should use the `-W`
argument to specify the working directory rather than calling `cd`
manually.
* The `system` invocation in your post-build block is not building for the
requested architecture. You should add `[get_canonical_archflags]` to the
flags sent to the compiler.
* `destroot.keepdirs` statements should usually be made outside of a
phase.
* Must you use `startupitem.start` and `startupitem.stop`? Using
`startupitem.executable` is preferable.
* Your `livecheck.url` has a doubled slash.
--
Ticket URL: <https://trac.macports.org/ticket/50121#comment:2>
MacPorts <https://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list