[MacPorts] #46754: llvm-3.* does not recognize -assertions (was: llvm-3.6 does not recognize -assertions)

[MacPorts]

#46754: llvm-3.* does not recognize -assertions
-----------------------+------------------------
  Reporter:  pguyot@…  |      Owner:  jeremyhu@…
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:  2.3.3
Resolution:            |   Keywords:
      Port:  llvm      |
-----------------------+------------------------
Description changed by pguyot@…:

Old description:

> Even when {{{-assertions}}} is passed, assertion mode is ON.
>
> I believe {{{--enable-assertions}}} is NOP and {{{--disable-assertions}}}
> should be passed instead as assertions are enabled by default.
> This probably is also the case with other versions of llvm.
>
> {{{./configure --help}}} indeed prints:
>
> {{{
>   --enable-assertions     Compile with assertion checks enabled (default
> is
>                           YES)
> }}}
>
> A patch is attached that fixes this. I didn't bump {{{revision}}},
> though.

New description:

 Even when {{{-assertions}}} is passed, assertion mode is ON.

 I believe {{{--enable-assertions}}} is NOP and {{{--disable-assertions}}}
 should be passed instead as assertions are enabled by default.
 This probably is also the case with other versions of llvm.

 {{{./configure --help}}} indeed prints:

 {{{
   --enable-assertions     Compile with assertion checks enabled (default
 is
                           YES)
 }}}

 A patch is attached that fixes this for llvm-3.6. I didn't bump
 {{{revision}}}, though. Yet, bumping revision is required at least for
 llvm-3.5 as the -assertions variant is available as a binary package (but
 with assertion-mode as ON).

--

-- 
Ticket URL: <https://trac.macports.org/ticket/46754#comment:1>
MacPorts <https://www.macports.org/>
Ports system for OS X