[MacPorts] #46811: xinit: typo in startx: Xorg wont start

[MacPorts]

#46811: xinit: typo in startx: Xorg wont start
----------------------+------------------------
  Reporter:  joerg@…  |      Owner:  jeremyhu@…
      Type:  defect   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.3.3
Resolution:           |   Keywords:
      Port:  xinit    |
----------------------+------------------------

Comment (by ryandesign@…):

 xinit appears to be using cpp to create this file. This appears to be ill-
 advised since this is not C code. This causes various warnings with the
 version of cpp in Yosemite's Xcode. like:

 {{{
 /usr/bin/cpp  -DXINITDIR=/opt/local/etc/X11/xinit -DXRDB=xrdb
 -DXMODMAP=xmodmap -DTWM=twm -DXCLOCK=xclock -DXTERM=xterm
 -DXSERVER=/opt/local/bin/X -DXAUTH=xauth -DXINIT=xinit
 -DLIBDIR=/opt/local/lib -DSHELL_CMD=/bin/sh -DHAS_COOKIE_MAKER
 -DMK_COOKIE="/opt/local/bin/openssl rand -hex 16"
 -D__libexecdir__="/opt/local/libexec" -D__bindir__="/opt/local/bin"
 -DBUNDLE_ID_PREFIX="org.macports" startx.cpp | /opt/local/bin/gsed -e '/^#
 *[0-9][0-9]*  *.*$/d' -e '/^#line  *[0-9][0-9]*  *.*$/d' -e '/^[
 ]*XCOMM$/s/XCOMM/#/' -e '/^[    ]*XCOMM[^a-zA-Z0-9_]/s/XCOMM/#/' -e '/^[
 ]*XHASH/s/XHASH/#/' -e '/\@\@$/s/\@\@$/\\/' > startx
 startx.cpp:24:19: warning: missing terminating ' character [-Winvalid-pp-
 token]
 XCOMM server there's a pretty good chance you want to bias the Xorg
 clients
                   ^
 startx.cpp:25:26: warning: missing terminating ' character [-Winvalid-pp-
 token]
 XCOMM over the old system's clients.
                          ^
 startx.cpp:95:4: error: invalid preprocessing directive
         # Don't push this into the background becasue it can cause
           ^
 startx.cpp:95:7: warning: missing terminating ' character [-Winvalid-pp-
 token]
         # Don't push this into the background becasue it can cause
              ^
 startx.cpp:132:11: warning: empty character constant [-Winvalid-pp-token]
     XCOMM '' required to prevent cpp from treating "/*" as a C comment.
           ^
 startx.cpp:133:6: warning: empty character constant [-Winvalid-pp-token]
     /''*|\./''*)
      ^
 startx.cpp:133:13: warning: empty character constant [-Winvalid-pp-token]
     /''*|\./''*)
             ^
 startx.cpp:305:13: warning: missing terminating '"' character [-Winvalid-
 pp-token]
 eval XINIT \"$client\" $clientargs -- \"$server\" $display $serverargs
             ^
 7 warnings and 1 error generated.
 }}}

 and with the version of cpp on Snow Leopard's Xcode, I guess it processes
 things differently in such a way that would not make a difference for C
 code but does for this code.

-- 
Ticket URL: <https://trac.macports.org/ticket/46811#comment:3>
MacPorts <https://www.macports.org/>
Ports system for OS X