[MacPorts] #38091: alpine @2.00_4: update to 2.11
MacPorts
noreply at macports.org
Wed Feb 25 18:49:05 PST 2015
#38091: alpine @2.00_4: update to 2.11
-----------------------+----------------------
Reporter: larryv@… | Owner: john@…
Type: update | Status: closed
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: fixed | Keywords: haspatch
Port: alpine |
-----------------------+----------------------
Comment (by jerryyhom@…):
OK, humor me while I try to understand your reply. Essentially, your
considerable efforts are to transition the portfile to explicit positive
variants while maintaining compatible behavior; after about a year, you
will remove the transitional code, completing the transformation to
explicit positive variants; everything is virtually identical. Please
correct me if my summary is wrong.
Now, hopefully these are received as constructive comments. Please
understand, my mindset is in trying to simplify and enhance alpine's
portfile. On one hand, your changes seemed to go the other way and
complicate it, but on the other hand, I think you could have saved
yourself some time. Let me know if we should discuss this directly via
email and off this ticket.
Generally, your explanation in your first paragraph probably belongs in
the Guide. The portfile recipes and perhaps many parts of the wiki could
go in the Guide.
Alpine specific, since you are cleaning up some depends_libs, the only
depends_lib necessary is openssl, at least on my 10.9 system. In fact,
because the upstream code does not conditionally code around it, the
--without-ssl option (and variant) is useless, and probably no one has
tried and complained. The libs iconv and ncurses are already provided by
OS X; if not on older systems, they could be conditional, but probably a
minor point here. Alpine builds on my system without gettext, but also
probably a minor point.
When or why did the without_tcl variant become obsolete? Do you mean
because MP implicitly has Tcl that the variant is obsolete? Your comment
in the portfile is unclear.
Two more comments which tie together. Overall, more commenting would
help, either in the portfile or descriptions about your changesets. You
are experienced, know what you are doing, and if you were the only one
looking at the code, you would easily go on doing fine work. However as
you know, portfiles are under scrutiny by others, usually maintainers. Of
course, you may do as you like as a committer, but as MP is a distributed
management system, please be more mindful of others reading your code. I
am trying to learn MP, but I am learning that the role of maintainer is
easily trampled over by committers.
--
Ticket URL: <https://trac.macports.org/ticket/38091#comment:39>
MacPorts <https://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list