[MacPorts] #46575: submission of the Charm time tracker for Qt4 or Qt5
MacPorts
noreply at macports.org
Thu Jan 15 18:23:07 PST 2015
#46575: submission of the Charm time tracker for Qt4 or Qt5
--------------------------+--------------------------------
Reporter: rjvbertin@… | Owner: macports-tickets@…
Type: submission | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords:
Port: Charm |
--------------------------+--------------------------------
Comment (by ryandesign@…):
Thanks. Some observations:
* Why call `github.setup` with a commit hash? Why not use the 1.8.0 tag?
Livecheck would work better and you wouldn't have to define `version`
separately.
* Why is `fetch.type git` necessary?
* The caterory should be changed because we do not have a category "qt".
* The `homepage` line should be removed because the github portgroup sets
it for you.
* Since the cmake portgroup seems to always be required, I'd recommend
including it at the top of the portfile right above the github portgroup
and removing it from the two subport blocks where you currently have it.
* Remove the quotation marks around the value of the `conflicts` option;
they're not needed.
* In the `post-destroot` block, remove the directory creation, because
MacPorts automatically creates standard directories for you.
* Use `${version}` in your `configure.args-append` statements instead of
hardcoding the version number there again.
--
Ticket URL: <https://trac.macports.org/ticket/46575#comment:2>
MacPorts <https://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list