[MacPorts] #47025: poppler: add Qt5 subport and optional test support.

[MacPorts]

#47025: poppler: add Qt5 subport and optional test support.
--------------------------+----------------------
  Reporter:  rjvbertin@…  |      Owner:  devans@…
      Type:  enhancement  |     Status:  assigned
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch
      Port:  poppler      |
--------------------------+----------------------
Changes (by devans@…):

 * cc: michaelld@…, mcalhoun@… (added)


Comment:

 Attached is my revised version of the submitted patch but issues remain
 before it can be committed.

 Poppler is updated to version 0.32.0.

 Rather than introducing the +test variant, which seems cumbersome to use,
 I have implemented the test function using the MacPorts test phase
 unconditionally but only for the subports.  I've verified that unit tests
 currently only exist for these subports and not for the base poppler.  For
 example to run the unit tests for poppler-qt4-mac you can now use the
 command

 {{{
 sudo port -d test poppler-qt4-mac
 }}}

 Without the -d option, the test runs silently unless a test error is
 detected.

 I have marked the two subports as conflicting since qt4-mac and qt5-mac
 still, unfortunately, conflict. I thought I saw a statement by michaelld
 that this situation had been fixed but apparently not.  This is one of the
 reasons that I have not added this subport before now.

 Additionally, the qt5 subport build continues to fail as I've seen it in
 the past.  This appears to be due to the
 difference in the way qt4 and qt5 install the include file hierarchy.  The
 poppler developers rely on the qt4 scheme for both qt4 and qt5.


 {{{
 libtool: compile:  /usr/bin/clang++ -DHAVE_CONFIG_H -I. -I../..
 -I../../poppler -I../.. -I../../poppler
 -I/opt/local/Library/Frameworks/Qt5Xml/Headers
 -I/opt/local/Library/Frameworks/Qt5Widgets/Headers
 -I/opt/local/Library/Frameworks/Qt5Gui/Headers
 -I/opt/local/Library/Frameworks/Qt5Core/Headers -I/opt/local/include
 -I/opt/local/include -Dpoppler_qt5_EXPORTS -fPIC -fPIC -Wall -Woverloaded-
 virtual -Wnon-virtual-dtor -Wcast-align -fno-exceptions -fno-common -pipe
 -Os -arch x86_64 -stdlib=libc++ -MT libpoppler_qt5_la-poppler-fontinfo.lo
 -MD -MP -MF .deps/libpoppler_qt5_la-poppler-fontinfo.Tpo -c poppler-
 fontinfo.cc  -fno-common -DPIC -o .libs/libpoppler_qt5_la-poppler-
 fontinfo.o
 In file included from poppler-fontinfo.cc:23:
 In file included from ./poppler-qt5.h:37:
 ./poppler-annotation.h:31:In file included from poppler-document.ccIn file
 included from In file included from :poppler-embeddedfile.cc:21poppler-
 page.cc27:
 In file included from :./poppler-qt5.h1034:
 :
 In file included from In file included from : fatal error: ./poppler-
 qt5.h'QtCore/QDateTime' file not found:
 37:
 ./poppler-qt5.h:37:
 ./poppler-annotation.h:31:10:./poppler-annotation.h :fatal error31:
 :'QtCore/QDateTime' file not found10
 : fatal error: 'QtCore/QDateTime' file not found
 #include <QtCore/QDateTime>
          ^
 #include <QtCore/QDateTime>
          ^
 #include <QtCore/QDateTime>
          ^
 :37:
 ./poppler-annotation.h:31:10: fatal error: 'QtCore/QDateTime' file not
 found
 #include <QtCore/QDateTime>
          ^
 1 error generated.
 1 error generated.
 make[4]: *** [libpoppler_qt5_la-poppler-fontinfo.lo] Error 1
 }}}

 Log file attached.

-- 
Ticket URL: <https://trac.macports.org/ticket/47025#comment:18>
MacPorts <https://www.macports.org/>
Ports system for OS X