[MacPorts] #33259: cmake portgroup: out of source build option, possibly by default

MacPorts noreply at macports.org
Tue Mar 10 16:00:55 PDT 2015


#33259: cmake portgroup: out of source build option, possibly by default
---------------------------+--------------------------------
  Reporter:  ryandesign@…  |      Owner:  macports-tickets@…
      Type:  enhancement   |     Status:  new
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:
Resolution:                |   Keywords:
      Port:                |
---------------------------+--------------------------------

Comment (by cal@…):

 I'd rather shorten the option name to `cmake.out_of_source` and use `yes`
 and `no` over `true` and `false` like we usually do. Your code only allows
 `true`, which is bad, because maintainers will try to set it to `yes` or
 `1`.

 Also, I'd rather modify the defaults than change the actual values when
 `cmake.out_of_source yes` is encountered in a Portfile. That would make
 {{{
 configure.dir ${worksrcpath}/foo
 cmake.out_of_source yes
 }}}
 work correctly. It's not obvious which side effects assigning to
 out_of_source has, otherwise.

-- 
Ticket URL: <https://trac.macports.org/ticket/33259#comment:21>
MacPorts <https://www.macports.org/>
Ports system for OS X


More information about the macports-tickets mailing list