[MacPorts] #47687: python portgroup should not auto-create ${destroot}${prefix}/share/doc/${subport}/examples
MacPorts
noreply at macports.org
Sat May 9 02:13:36 PDT 2015
#47687: python portgroup should not auto-create
${destroot}${prefix}/share/doc/${subport}/examples
---------------------------+--------------------------
Reporter: ryandesign@… | Owner: ryandesign@…
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 2.3.99
Resolution: | Keywords:
Port: python |
---------------------------+--------------------------
Comment (by ryandesign@…):
Just wanted to Cc you since it had been your mailing list post.
Having MacPorts base provide an option pre-set to the correct docdir is
interesting. If we do provide this option in base, it should ''not'' begin
with `${destroot}` because sometimes you want to pass it as an argument to
a configure script, display it in `notes`, or `reinplace` it into
installed files.
Many ports already use the variable `docdir` for this, as recommended in
my [PortfileRecipes#doc recipe]. I ''think'' having MacPorts base define
an option of the same name wouldn't cause a problem but I'm not sure.
I was going to audit and update the python ports now, which would mean
potentially having to update ports again later—if this MacPorts base
option gets added—if only to remove setting `docdir`.
Providing another option to automatically create the directory is
superfluous. If a portfile author is going to install documentation files
manually, it's just as easy to write:
{{{
post-destroot {
xinstall -d ${destroot}${docdir}
xinstall -m 644 ${worksrcpath}/README ${destroot}${docdir}
}
}}}
as it would be to write:
{{{
destroot.create_docdir yes
post-destroot {
xinstall -m 644 ${worksrcpath}/README ${destroot}${docdir}
}
}}}
In any case in this ticket I only want to handle removing the default
creation of the examples directory from the python portgroup, and the
fallout from that. I think discussions of adding an option to MacPorts
base, using it in other ports, and auditing other ports for correct docdir
usage is outside the scope of this ticket.
--
Ticket URL: <https://trac.macports.org/ticket/47687#comment:5>
MacPorts <https://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list