[MacPorts] #49058: apbs: several minor enhancements

[MacPorts]

#49058: apbs: several minor enhancements
--------------------------+-----------------------------------
  Reporter:  dstrubbe@…   |      Owner:  howarth.at.macports@…
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:  2.3.4
Resolution:  fixed        |   Keywords:  haspatch
      Port:  apbs         |
--------------------------+-----------------------------------

Comment (by dstrubbe@…):

 Ok, I see that the parallel build apparently is responsible for the
 failures to find the files for Eigen (internal, not from eigen3 port) and
 apbs_geoflow, evidently due to some bugs in the APBS build system.

 This part, and your preferred way of managing the directory structure,
 committed in r142365. (Let me point out that the cmake portgroup always
 specifies the directory explicitly in the configure step anyway. Take a
 look at the command it executes, which will end in ${worksrcpath}.)

 Your fix for BEM is a good start but insufficient: the build automatically
 detects a Fortran compiler, not necessarily gcc5. In my case it found and
 used g95, which failed to link with the gcc5 library not surprisingly.
 More patching is needed. The ultimate problem is that configure gets run

 The lines you added about include paths have no effect:
 "-I${prefix}/include" is the default so it's already used;
 "-I${worksrcpath}/include" does not exist as a path. Such things (when
 needed) are really supposed to go into CFLAGS not the C compiler command
 directly, anyway.

 Since we are including the compilers portgroup, we should use it for
 support for Fortran, rather than doing it by hand. It is typical to create
 a variant in a situation like this for BEM, since it introduces an
 additional dependency.

-- 
Ticket URL: <https://trac.macports.org/ticket/49058#comment:18>
MacPorts <https://www.macports.org/>
Ports system for OS X