[MacPorts] #49120: port:automoc should install its cmake files where others expect them

MacPorts noreply at macports.org
Mon Oct 5 19:03:50 PDT 2015


#49120: port:automoc should install its cmake files where others expect them
--------------------------+--------------------------------
  Reporter:  rjvbertin@…  |      Owner:  macports-tickets@…
      Type:  defect       |     Status:  closed
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:  worksforme   |   Keywords:  haspatch
      Port:  automoc      |
--------------------------+--------------------------------
Changes (by michaelld@…):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 The changes moved the cmake files from ${prefix}/lib/cmake to
 ${prefix}/share/cmake . Both of these directories are searched by cmake
 -by default- for modules (new-style Find* scripts). We in MP land prefer
 (for some reason) to install cmake scripts into the latter. Hence the
 change.

 I just installed phonon on a fresh MP 10.11 build. Works fine.

 polkit-qt provides its own FindAutomoc4.cmake file which isn't robustly
 written. It should not rely on cmake scripts being in solely ${prefix} or
 ${prefix}/lib. In my projects, we use CMAKE_MODULE_PATH (ditto for the
 cmake PortGroup) -- a separate variable that robustly allows for these
 files to be anywhere. Removing the FindAutomoc4.cmake and trusting cmake
 and the files provided by automoc4, all is well again.

 A well-written build script will survive these sorts of changes.

 I'd much prefer to fix polkit-qt rather than revert something that already
 works.

-- 
Ticket URL: <https://trac.macports.org/ticket/49120#comment:2>
MacPorts <https://www.macports.org/>
Ports system for OS X


More information about the macports-tickets mailing list