[MacPorts] #49051: Update: VLC 2.2.1 with fix for the lua 5.3 incompatibility

[MacPorts]

#49051: Update: VLC 2.2.1 with fix for the lua 5.3 incompatibility
--------------------------+---------------------------------
  Reporter:  rjvbertin@…  |      Owner:  macports-tickets@…
      Type:  update       |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch maintainer
      Port:  VLC          |
--------------------------+---------------------------------

Comment (by framic5@…):

 Replying to [comment:8 rjvbertin@…]:
 > If you're interested, you can do search for l-framework after `port
 extract VLC`, `port patch VLC`, and `port configure VLC`. It might even be
 a good idea to do it after the autoreconf step (by interrupting or
 suspending the port command as soon as the actual configure command is
 started).
 No matches after `port extract`, `port patch` and autoreconf (interrupted
 by setting `configure.cmd` to an invalid command). After `port configure`
 I get 94 matches (87 in several Makefiles, rest in `config.log` and
 `config.status`).

 I'm wondering why I only run into problems with the video_filter Makefile
 and not with the others. I looked at the failing command again and saw,
 that the linker flag is truncated:
 {{{
 libtool: link: /usr/bin/clang  -o .libs/libopencv_wrapper_plugin.dylib
 -bundle  .libs/libopencv_wrapper_plugin_la-opencv_wrapper.o
 ../../compat/.libs/libcompat.a -L/opt/local/lib
 -L/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_multimedia_VLC/VLC/work/vlc-2.2.1/contrib/lib
 ../../src/.libs/libvlccore.dylib -lintl -lidn -liconv -lm -lopencv_shape
 -lopencv_stitching -lopencv_objdetect -lopencv_superres -lopencv_videostab
 -lopencv_calib3d -lopencv_features2d -lopencv_highgui -lopencv_videoio
 -lopencv_imgcodecs -lopencv_video -lopencv_photo -lopencv_ml
 -lopencv_imgproc -lopencv_flann -lopencv_core -lopencv_hal -lpng -ltiff
 -ljasper -ljpeg -lImath -lIlmImf -lIex -lHalf -lIlmThread -lavcodec
 -lavformat -lavutil -lswscale -lavresample -lz -lbz2 -l-framework  -Os
 -arch x86_64 -O3 -Wl,-headerpad_max_install_names -arch x86_64
 -Wl,-headerpad_max_install_names   -Wl,-exported_symbols_list,.libs
 /libopencv_wrapper_plugin-symbols.expsym
 ld: library not found for -l-framework
 clang: error: linker command failed with exit code 1 (use -v to see
 invocation)
 make[5]: *** [libopencv_wrapper_plugin.la] Error 1
 }}}
 `-l-framework ` is everything what's left from 5 flags. Compared to the
 command after I apply my patch on Makefile:
 {{{
 libtool: link: /usr/bin/clang  -o .libs/libopencv_wrapper_plugin.dylib
 -bundle  .libs/libopencv_wrapper_plugin_la-opencv_wrapper.o
 ../../compat/.libs/libcompat.a -L/opt/local/lib
 -L/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_multimedia_VLC/VLC/work/vlc-2.2.1/contrib/lib
 ../../src/.libs/libvlccore.dylib -lintl -lidn -liconv -lm -lopencv_shape
 -lopencv_stitching -lopencv_objdetect -lopencv_superres -lopencv_videostab
 -lopencv_calib3d -lopencv_features2d -lopencv_highgui -lopencv_videoio
 -lopencv_imgcodecs -lopencv_video -lopencv_photo -lopencv_ml
 -lopencv_imgproc -lopencv_flann -lopencv_core -lopencv_hal -lpng -ltiff
 -ljasper -ljpeg -lImath -lIlmImf -lIex -lHalf -lIlmThread -lavcodec
 -lavformat -lavutil -lswscale -lavresample -lz -lbz2  -Os -arch x86_64 -O3
 -Wl,-headerpad_max_install_names -arch x86_64
 -Wl,-headerpad_max_install_names -Wl,-framework -Wl,Cocoa -Wl,-framework
 -Wl,VideoDecodeAcceleration -Wl,-framework -Wl,QTKit -Wl,-framework
 -Wl,QuartzCore -Wl,-framework -Wl,AppKit
 -Wl,-exported_symbols_list,.libs/libopencv_wrapper_plugin-symbols.expsym
 }}}

 > What does your log show for these 2 lines?
 {{{
 :info:configure checking build system type... x86_64-apple-darwin15.0.0
 :info:configure checking host system type... x86_64-apple-darwin15.0.0
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/49051#comment:9>
MacPorts <https://www.macports.org/>
Ports system for OS X