[MacPorts] #49446: TeXShop3 @3.57: identical patch blocks for darwin 12, 13, 14

[MacPorts]

#49446: TeXShop3 @3.57: identical patch blocks for darwin 12, 13, 14
--------------------------+----------------------
 Reporter:  ryandesign@…  |      Owner:  jwa@…
     Type:  enhancement   |     Status:  new
 Priority:  Normal        |  Milestone:
Component:  ports         |    Version:  2.3.4
 Keywords:                |       Port:  TeXShop3
--------------------------+----------------------
 I noticed that the TeXShop3 port has identical patch blocks for darwin 12,
 13 and 14:

 {{{
 platform darwin 12 {
     patchfiles-append   patch-MyPDFKitView.m.diff patch-
 TSAppDelegate.m.diff \
         patch-MyPDFKitView-Magnification.m.diff
 }

 platform darwin 13 {
     patchfiles-append   patch-MyPDFKitView.m.diff patch-
 TSAppDelegate.m.diff \
         patch-MyPDFKitView-Magnification.m.diff
 }

 platform darwin 14 {
     patchfiles-append   patch-TSAppDelegate.m.diff \
         patch-MyPDFKitView-Magnification.m.diff
 }
 }}}

 Why not make these a single block?

 {{{
 platform darwin {
     if {${os.major} >= 12 && ${os.major} <= 14} {
         patchfiles-append   patch-MyPDFKitView.m.diff \
                             patch-MyPDFKitView-Magnification.m.diff \
                             patch-TSAppDelegate.m.diff
     }
 }
 }}}

 Even better would be if the patches were written in such a way that it
 will work correctly for any version of OS, and applied unconditionally.
 That's what would be required for the patch to be accepted by the upstream
 developers.

-- 
Ticket URL: <https://trac.macports.org/ticket/49446>
MacPorts <https://www.macports.org/>
Ports system for OS X