[MacPorts] #48413: py-horton @2.0.0 Quantum_chemistry_python_package
MacPorts
noreply at macports.org
Wed Sep 16 08:09:59 PDT 2015
#48413: py-horton @2.0.0 Quantum_chemistry_python_package
-------------------------+--------------------------------
Reporter: yangx59@… | Owner: macports-tickets@…
Type: submission | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords:
Port: py-horton |
-------------------------+--------------------------------
Comment (by yangx59@…):
Replying to [comment:16 petr@…]:
> Hi Xiaotian,
>
> here some notes on the updated Portfile:
>
> I think above all you have not fully address Rainer's question on
whether this should not be installed simply as an App, instead as module.
>
> Here some background: The python portgroup supports to modes for modules
and for applications, this is controlled by the name of the port (py-* are
for modules, otherwise it is treated as application). Modules can be
installed for multiple versions of python and conflicts are avoided by
appending the `-${python.branch}` postfix.
>
> In `post-destroot` you revert this behavior, making it impossible to
install against several versions of python contemporary. As long as you do
have only python 2.7, this will not surface, but then you probably do not
intend to install a module and you should create an app.
>
> If you think this should be a module and more Python versions could be
supported in future, you need to remove the `post-destroot` overwrite, and
if you want script names w/o suffix, you need to use the select mechanism.
>
> I would recommend you to add `openmaintainer`.
>
>
> The following settings are defaults and should be removed:
>
> {{{
> extract.suffix .tar.gz
>
> [...]
> distname ${name}-${version}
> distfiles ${distname}${extract.suffix}
> }}}
>
> Instead of `file copy` use the Macports alias `copy`
>
> `livecheck` should be set correctly by the the Github portgroup, so
avoid overwriting it.
>
Thanks for your review. I changed it into an application and it make the
portfile much easier and readable. Duplicated parts are deleted as well
as the some of the redundent post-destroot part.
livecheck.type is changed to none
Test it on my own laptop. Installed smoothly and all the tests are ok.
Would you please take some time to review it again.
BTW, I would like to add openmaintainer but how do I do that.
--
Ticket URL: <https://trac.macports.org/ticket/48413#comment:17>
MacPorts <https://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list