[MacPorts] #48892: httping 2.4 no longer has ncurses mode
MacPorts
noreply at macports.org
Thu Sep 17 06:01:26 PDT 2015
#48892: httping 2.4 no longer has ncurses mode
-----------------------------+--------------------------
Reporter: brian.reiter@… | Owner: ryandesign@…
Type: enhancement | Status: assigned
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords: haspatch
Port: httping |
-----------------------------+--------------------------
Changes (by ryandesign@…):
* status: new => assigned
* owner: macports-tickets@… => ryandesign@…
Comment:
Thanks.
To use a configure script, we would just remove "use_configure no". We
would not add "use_configure yes", because that is the default.
The default value of configure.cmd is "./configure", which is what we
would use here. We would add any needed arguments to configure.args. By
default MacPorts will also put "--prefix=${prefix}" into
configure.pre_args; if that is unsuitable for this configure script, it
can be cleared.
This configure script uses mktemp in a way that is not compatible with OS
X, which causes error messages to be printed and probably causes the temp
files not to be created, which could cause the configure script to
function incorrectly. I see you're attempting to redirect stderr to
/dev/null, perhaps to hide these errors. I'd prefer to fix the configure
script so that is uses mktemp correctly.
Your changes introduced tab characters into the portfile, but you should
try to match the existing whitespace of the portfile, which in this case
uses spaces. That's our preferred style, and it's also what the modeline
of this portfile states.
Probably, the extra library flags being added to LDFLAGS will no longer be
needed once the configure script is being used.
--
Ticket URL: <https://trac.macports.org/ticket/48892#comment:2>
MacPorts <https://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list