[MacPorts] #48862: astyle: update to 2.05.1

MacPorts noreply at macports.org
Fri Sep 18 05:27:36 PDT 2015


#48862: astyle: update to 2.05.1
---------------------+--------------------------
  Reporter:  jhi@…   |      Owner:  ryandesign@…
      Type:  update  |     Status:  assigned
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch
      Port:  astyle  |
---------------------+--------------------------
Changes (by ryandesign@…):

 * keywords:   => haspatch


Comment:

 I'm attaching an update which works for me.

 - I updated the version and checksums, of course.
 - I adjusted the master_sites to [wiki:howto/AvoidRedirects avoid
 redirects].
 - The patchfile that changed JAVAHOME no longer applied; I used the java
 1.0 portgroup in the hopes that its method of finding the Java
 installation is more robust than what we were previously doing.
 - I'm using the muniversal portgroup because building universal failed
 without it:
 {{{
 ar: bin/libastyle.a is a fat file (use libtool(1) or lipo(1) and ar(1) on
 it)
 ar: bin/libastyle.a: Inappropriate file type or format
 }}}
 - I removed the lib variant and made the port always build and install the
 libraries. The point of installing libraries is so that other software can
 use it. If that other software is in MacPorts, it needs to be able to
 assume the libraries are there, and not require the user to manually
 reinstall the port with the lib variant.
 - The libraries didn't have their install_name set, which is mandatory if
 other programs are going to be linked with them. I modified the Makefile
 patch to set the install_name, though the value to which I've set it is
 bad because it will presumably change with every astyle version. It should
 only change with every major astyle library version, but the astyle
 developers don't appear to be assigning library version numbers. This is
 not surprising since they also aren't providing Makefile targets for
 installing libraries; that's part of what the port adds in the Makefile
 patch. We should work with the developers of astyle to get our changes
 incorporated into their official sources and get them to correctly version
 the libraries. Ideally, they would switch their build system to autoconf
 which would automatically correctly handle these aspects of library
 building.

 There is also an Xcode project in this version of astyle which can be used
 instead of the Makefile but I didn't look into it.

 wyuenho, if there are no objections, I'm happy to commit these changes.

-- 
Ticket URL: <https://trac.macports.org/ticket/48862#comment:2>
MacPorts <https://www.macports.org/>
Ports system for OS X


More information about the macports-tickets mailing list