[MacPorts] #52008: aria2 @1.24.0 Snow Leopard build error related to AppleTLSContext.cc; and fix

[MacPorts]

#52008: aria2 @1.24.0 Snow Leopard build error related to AppleTLSContext.cc; and
fix
-------------------------------------+-------------------------
  Reporter:  kenneth.f.cunningham@…  |      Owner:  mww@…
      Type:  defect                  |     Status:  new
  Priority:  Normal                  |  Milestone:
 Component:  ports                   |    Version:  2.3.4
Resolution:                          |   Keywords:  snowleopard
      Port:  aria2                   |
-------------------------------------+-------------------------
Changes (by mf2k@…):

 * cc: mww@… (removed)
 * keywords:  Snow Leopard => snowleopard
 * owner:  macports-tickets@… => mww@…


Old description:

> Aria2 @1.24 build fails on Snow Leopard due to AppleTLSContext errors. I
> see a previous bug report for an earlier version of aria2 regarding this
> same issue <https://trac.macports.org/ticket/39100>.
>
> Here is the error:
> {{{
> AppleTLSContext.cc:294:10: error: no matching function for call to
> 'SecIdentitySearchCopyNext'
>   while (SecIdentitySearchCopyNext(search, &id) == errSecSuccess) {
> }}}
>
> A little surgery on the function seemed to get the build to proceed:
> {{{
> change to
>   while (SecIdentitySearchCopyNext((SecIdentitySearchRef)&raw_search,
> &id) == errSecSuccess) {
> }}}
>  but then failed during link:
> {{{
> Undefined symbols for architecture x86_64:
>   "_kSecImportExportPassphrase", referenced from:
>       aria2::AppleTLSContext::tryAsPKCS12(__CFData const*, char const*)
> in libaria2.a(AppleTLSContext.o)
>   "_kSecImportItemIdentity", referenced from:
>       aria2::AppleTLSContext::tryAsPKCS12(__CFData const*, char const*)
> in libaria2.a(AppleTLSContext.o)
> ld: symbol(s) not found for architecture x86_64
> }}}
>
> So ultimately disabled apple-tls on Snow Leopard, and build succeeds.
> Diff attached.
> Note - aria2 requires c++11, and so the
> <https://trac.macports.org/wiki/LibcxxOnOlderSystems> modification for
> Snow Leopard is presumably required. I didn't try it without the libcxx
> modification.

New description:

 Aria2 @1.24 build fails on Snow Leopard due to AppleTLSContext errors. I
 see a previous bug report for an earlier version of aria2 regarding this
 same issue ticket:39100.

 Here is the error:
 {{{
 AppleTLSContext.cc:294:10: error: no matching function for call to
 'SecIdentitySearchCopyNext'
   while (SecIdentitySearchCopyNext(search, &id) == errSecSuccess) {
 }}}

 A little surgery on the function seemed to get the build to proceed:
 {{{
 change to
   while (SecIdentitySearchCopyNext((SecIdentitySearchRef)&raw_search, &id)
 == errSecSuccess) {
 }}}
  but then failed during link:
 {{{
 Undefined symbols for architecture x86_64:
   "_kSecImportExportPassphrase", referenced from:
       aria2::AppleTLSContext::tryAsPKCS12(__CFData const*, char const*) in
 libaria2.a(AppleTLSContext.o)
   "_kSecImportItemIdentity", referenced from:
       aria2::AppleTLSContext::tryAsPKCS12(__CFData const*, char const*) in
 libaria2.a(AppleTLSContext.o)
 ld: symbol(s) not found for architecture x86_64
 }}}

 So ultimately disabled apple-tls on Snow Leopard, and build succeeds. Diff
 attached.
 Note - aria2 requires c++11, and so the wiki:LibcxxOnOlderSystems
 modification for Snow Leopard is presumably required. I didn't try it
 without the libcxx modification.

--

-- 
Ticket URL: <https://trac.macports.org/ticket/52008#comment:2>
MacPorts <https://www.macports.org/>
Ports system for OS X