[MacPorts] #51344: seqan @2.1.1_0 Fixes installation of missing files

MacPorts noreply at macports.org
Fri Dec 9 13:26:00 CET 2016


#51344: seqan @2.1.1_0 Fixes installation of missing files
---------------------+---------------------------------
  Reporter:  rrahn   |      Owner:  macports-tickets@…
      Type:  defect  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:  2.3.4
Resolution:          |   Keywords:  haspatch maintainer
      Port:  seqan   |
---------------------+---------------------------------

Comment (by raimue):

 The preferred format for diffs would be unified, which is usually created
 by running `diff -u Portfile.orig Portfile` as described in
 [https://guide.macports.org/#development.patches.portfile the guide].

 Are you sure these are the right changes? The directory structure you are
 creating does not make sense.

   * The previous copy statement for `include` looked fine. What is the
 addition of a trailing slash supposed to solve?
   * This now creates `${prefix}/share/doc/doc/seqan/` (duplicate `doc/`)
   * The `.pc` file needs to go to `${prefix}/lib/pkgconfig/`. Similarly
 for the `.cmake` file, which would be expected in
 `${prefix}/lib/cmake/${name}/`. What is the point in not putting them into
 the default search paths?

--
Ticket URL: <https://trac.macports.org/ticket/51344#comment:9>
MacPorts <https://www.macports.org/>
Ports system for macOS


More information about the macports-tickets mailing list