[MacPorts] #53083: VLC: fails to build on Sierra due to QtKit

[MacPorts]

#53083: VLC: fails to build on Sierra due to QtKit
---------------------+--------------------
  Reporter:  mkae    |      Owner:
      Type:  defect  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  sierra
      Port:  VLC     |
---------------------+--------------------

Comment (by RJVB):

 Indeed, I c/should have foreseen this.

 Do you have a VM to check if this patch fixes the issue?

 {{{
 diff --git a/multimedia/VLC/Portfile b/multimedia/VLC/Portfile
 index 96cd43cb..6d859d84 100644
 --- a/multimedia/VLC/Portfile
 +++ b/multimedia/VLC/Portfile
 @@ -335,8 +335,11 @@ if {(${subport} eq ${name}) || (${subport} eq
 "lib${name}")} {
          configure.args-replace  --disable-dbus --enable-dbus
      }

 -    variant qtkit description {Enable qtcapture and qtaudio} {
 -        configure.args-replace  --disable-macosx-qtkit --enable-macosx-
 qtkit
 +    if {${os.major} <= 15} {
 +        # QTKit was disabled in 10.12 "Sierra"
 +        variant qtkit description {Enable qtcapture and qtaudio} {
 +            configure.args-replace  --disable-macosx-qtkit --enable-
 macosx-qtkit
 +        }
      }

      variant svg description {Enable SVG rendering and decoding support} {
 @@ -448,7 +451,10 @@ if {(${subport} eq ${name}) || (${subport} eq
 "lib${name}")} {
      patchfiles-append           patch-for-lua52.diff

      platform macosx {
 -        default_variants-append +quartz +qtkit
 +        default_variants-append +quartz
 +        if {[variant_exists qtkit]} {
 +            default_variants-append +qtkit
 +        }

          configure.args-replace  --disable-macosx-eyetv --enable-macosx-
 eyetv

 }}}

--
Ticket URL: <https://trac.macports.org/ticket/53083#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS