[MacPorts] #50701: wxWidgets: add patches to support KiCad

MacPorts noreply at macports.org
Tue Feb 23 23:29:05 PST 2016


#50701: wxWidgets: add patches to support KiCad
-----------------------------------+---------------------
  Reporter:  mojca@…               |      Owner:  mojca@…
      Type:  defect                |     Status:  new
  Priority:  Normal                |  Milestone:
 Component:  ports                 |    Version:
Resolution:                        |   Keywords:
      Port:  wxWidgets-3.0, kicad  |
-----------------------------------+---------------------
Description changed by mojca@…:

Old description:

> KiCad (#47268) requires some patches of wxWidgets. Here's a list of
> [http://bazaar.launchpad.net/~kicad-product-
> committers/kicad/product/files/head:/patches/ patches] for wxWidgets from
> the KiCad's [http://ci.kicad-pcb.org/job/kicad-
> doxygen/ws/Documentation/doxygen/html/md_Documentation_development_compiling.html
> build instructions]:
>
> === in master ===
>
> - [http://bazaar.launchpad.net/~kicad-product-
> committers/kicad/product/view/head:/patches/wxwidgets-3.0.0_macosx_scrolledwindow.patch
> wxwidgets-3.0.0_macosx_scrolledwindow.patch] (include; also in 3.0
> branch)
>   - some scrolling events
> - [http://bazaar.launchpad.net/~kicad-product-
> committers/kicad/product/view/head:/patches/wxwidgets-3.0.2_macosx_magnify_event.patch
> wxwidgets-3.0.2_macosx_magnify_event.patch] (include; not in 3.0 branch)
>   - adds support for a magnifying mouse gesture (possibly compare the
> patch with `master`)
>
> === not in master ===
>
> - [http://bazaar.launchpad.net/~kicad-product-
> committers/kicad/product/view/head:/patches/wxpython-3.0.0_macosx_multiarch.patch
> wxpython-3.0.0_macosx_multiarch.patch]
>   - handles arch flags in build scripts, most likely not needed
> - [http://bazaar.launchpad.net/~kicad-product-
> committers/kicad/product/view/head:/patches/wxwidgets-3.0.0_macosx.patch
> wxwidgets-3.0.0_macosx.patch]
>   - it replaces carbon with cocoa at some places and fixes overlays (I
> don't completely understand it)
>   - the patch for wxPython is slightly different from the patch for
> wxWidgets (why?)
> - [http://bazaar.launchpad.net/~kicad-product-
> committers/kicad/product/view/head:/patches/wxwidgets-3.0.0_macosx_bug_15908.patch
> wxwidgets-3.0.0_macosx_bug_15908.patch]
>   - some dirty patch to avoid crashes (I don't understand it, not sure
> what to do)
>   - see also http://trac.wxwidgets.org/ticket/15908
> - [http://bazaar.launchpad.net/~kicad-product-
> committers/kicad/product/view/head:/patches/wxwidgets-3.0.0_macosx_soname.patch
> wxwidgets-3.0.0_macosx_soname.patch]
>   - it avoids running `change-install-names`
>   - similar patch was already in MacPorts in the past; see also
> http://trac.wxwidgets.org/ticket/15452
>   - most likely this is some weird practice of wxWidgets build system,
> but wxWidgets should work fine with the patch or without
> - [http://bazaar.launchpad.net/~kicad-product-
> committers/kicad/product/view/head:/patches/wxwidgets-3.0.2_macosx_data_view_ctrl.patch
> wxwidgets-3.0.2_macosx_data_view_ctrl.patch]
>   - I don't understand it
> - [http://bazaar.launchpad.net/~kicad-product-
> committers/kicad/product/view/head:/patches/wxwidgets-3.0.2_macosx_retina_opengl.patch
> wxwidgets-3.0.2_macosx_retina_opengl.patch]
>   - conflicting informations are circulating around about support of
> retina displays, so I'm a bit confused about why this is needed
>   - see also https://forums.wxwidgets.org/viewtopic.php?t=36684
>   - see also https://wiki.wxwidgets.org/WxMac-
> specific_topics#Retina_display_support
> - [http://bazaar.launchpad.net/~kicad-product-
> committers/kicad/product/view/head:/patches/wxwidgets-3.0.2_macosx_yosemite.patch
> wxwidgets-3.0.2_macosx_yosemite.patch]
>   - why exactly is this needed and not included upstream?
>   - should the patch only be applied to Yosemite (and El Capitan) or to
> all versions?
>
> And here's an [http://bazaar.launchpad.net/~adamwolf/+junk/kicad-mac-
> packaging/files alternative link] with patches and build scripts.

New description:

 KiCad (#47268) requires some patches of wxWidgets. Here's a list of
 [http://bazaar.launchpad.net/~kicad-product-
 committers/kicad/product/files/head:/patches/ patches] for wxWidgets from
 the KiCad's [http://ci.kicad-pcb.org/job/kicad-
 doxygen/ws/Documentation/doxygen/html/md_Documentation_development_compiling.html
 build instructions]:

 === in master ===

 - [http://bazaar.launchpad.net/~kicad-product-
 committers/kicad/product/view/head:/patches/wxwidgets-3.0.0_macosx_scrolledwindow.patch
 wxwidgets-3.0.0_macosx_scrolledwindow.patch] (include; also in 3.0 branch)
   - Some scrolling events
 - [http://bazaar.launchpad.net/~kicad-product-
 committers/kicad/product/view/head:/patches/wxwidgets-3.0.2_macosx_magnify_event.patch
 wxwidgets-3.0.2_macosx_magnify_event.patch] (include; not in 3.0 branch)
   - Adds support for a magnifying mouse gesture (possibly compare the
 patch with `master`)

 === not in master ===

 - [http://bazaar.launchpad.net/~kicad-product-
 committers/kicad/product/view/head:/patches/wxpython-3.0.0_macosx_multiarch.patch
 wxpython-3.0.0_macosx_multiarch.patch]
   - Handles arch flags in build scripts, most likely not needed
 - [http://bazaar.launchpad.net/~kicad-product-
 committers/kicad/product/view/head:/patches/wxwidgets-3.0.0_macosx.patch
 wxwidgets-3.0.0_macosx.patch] and [http://bazaar.launchpad.net/~kicad-
 product-
 committers/kicad/product/view/head:/patches/wxpython-3.0.0_macosx.patch
 wxpython-3.0.0_macosx.patch]
   - iI replaces carbon with cocoa at some places and fixes overlays (I
 don't completely understand it)
   - The patch for wxPython is slightly different from the patch for
 wxWidgets (why?)
   - Is there any ticket on the wxWidgets tracker about this issue?
 - [http://bazaar.launchpad.net/~kicad-product-
 committers/kicad/product/view/head:/patches/wxwidgets-3.0.0_macosx_bug_15908.patch
 wxwidgets-3.0.0_macosx_bug_15908.patch]
   - Some dirty patch to avoid crashes (I don't understand it, not sure
 what to do)
   - See also http://trac.wxwidgets.org/ticket/15908
 - [http://bazaar.launchpad.net/~kicad-product-
 committers/kicad/product/view/head:/patches/wxwidgets-3.0.0_macosx_soname.patch
 wxwidgets-3.0.0_macosx_soname.patch]
   - It avoids running `change-install-names`
   - Similar patch was already in MacPorts in the past; see also
 http://trac.wxwidgets.org/ticket/15452
   - Most likely this is some weird practice of wxWidgets build system, but
 wxWidgets should work fine for us either with the patch or without
 - [http://bazaar.launchpad.net/~kicad-product-
 committers/kicad/product/view/head:/patches/wxwidgets-3.0.2_macosx_data_view_ctrl.patch
 wxwidgets-3.0.2_macosx_data_view_ctrl.patch]
   - I don't understand it
 - [http://bazaar.launchpad.net/~kicad-product-
 committers/kicad/product/view/head:/patches/wxwidgets-3.0.2_macosx_retina_opengl.patch
 wxwidgets-3.0.2_macosx_retina_opengl.patch]
   - Conflicting informations are circulating around about support of
 retina displays, so I'm a bit confused about why this is needed
   - See also https://forums.wxwidgets.org/viewtopic.php?t=36684
   - See also https://wiki.wxwidgets.org/WxMac-
 specific_topics#Retina_display_support
 - [http://bazaar.launchpad.net/~kicad-product-
 committers/kicad/product/view/head:/patches/wxwidgets-3.0.2_macosx_yosemite.patch
 wxwidgets-3.0.2_macosx_yosemite.patch]
   - Why exactly is this needed and not included upstream?
   - Should the patch only be applied to Yosemite (and El Capitan) or to
 all versions?

 And here's an [http://bazaar.launchpad.net/~adamwolf/+junk/kicad-mac-
 packaging/files alternative link] with patches and build scripts.

--

-- 
Ticket URL: <https://trac.macports.org/ticket/50701#comment:3>
MacPorts <https://www.macports.org/>
Ports system for OS X


More information about the macports-tickets mailing list