[MacPorts] #50310: p5-musicbrainz-discid: patch fails

MacPorts noreply at macports.org
Thu Jan 14 00:43:28 PST 2016


#50310: p5-musicbrainz-discid: patch fails
------------------------------------+---------------------------
  Reporter:  mojca@…                |      Owner:  khindenburg@…
      Type:  defect                 |     Status:  new
  Priority:  Normal                 |  Milestone:
 Component:  ports                  |    Version:
Resolution:                         |   Keywords:
      Port:  p5-musicbrainz-discid  |
------------------------------------+---------------------------

Comment (by mojca@…):

 Nice catch. When I saw the error on the buildbot (please keep in mind that
 buildbot will try `port patch p5-musicbrainz-discid` in any case, so this
 has to be fixed) and tried to reproduce it, I got the same error without
 much thinking. After "fixing the problem" with `-p1` vs. `-p0`, I tried
 `p5.22-musicbrainz-discid` of course. (If I would commit that change
 afterwards, I would probably have noticed another problem ... :)

 So you need to put
 {{{
 if {${perl5.major} != ""} {
 }}}
 above the patches. I would still suggest you to fix `"Hunk #1 succeeded at
 31 (offset 3 lines)."` and I would remove `-p1`, but that is up to you.
 (You probably wanted to keep 100% original patches from somewhere
 upstream?)

-- 
Ticket URL: <https://trac.macports.org/ticket/50310#comment:3>
MacPorts <https://www.macports.org/>
Ports system for OS X


More information about the macports-tickets mailing list