[MacPorts] #51863: New Port ChezScheme
MacPorts
noreply at macports.org
Sun Jul 17 15:03:18 PDT 2016
#51863: New Port ChezScheme
----------------------------+--------------------------------
Reporter: watsonbladd@… | Owner: macports-tickets@…
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 2.3.4
Resolution: | Keywords:
Port: chezscheme |
----------------------------+--------------------------------
Comment (by cal@…):
A couple of lint warnings:
{{{
$ port lint --nitpick
---> Verifying Portfile for ChezScheme
Warning: Line 5 should be a newline (after PortSystem)
Warning: Line 11 seems to hardcode the version number, consider using
${version} instead
Warning: Line 25 has trailing whitespace before newline
Warning: no license set
---> 0 errors and 4 warnings found.
}}}
A couple of comments:
- Your whitespace doesn't match the modeline; we usually use 4 spaces for
indentation, but your Portfile uses a mix of spaces and tabs.
- Instead of `build.target-delete all`, I'd just use `build.target`
(without anything after it), which sets `build.target` to empty, like you
did it for `configure.pre_args`.
- The port uses curl to download additional files in the build phase. Can
this be avoided?
- The port seems to unconditionally use `gcc` to compile. We want it to
use `$CC` from the environment and pay attention to our `$CFLAGS` (which
it seems to do) and `$LDFLAGS`.
- The port seems to build its own copy of zlib. It should use MacPorts'
zlib instead. Additionally, the copy of zlib requires Xlib headers which
causes the build to fail ![1] and compiles a library that is only suitable
for installing in `/usr/local/lib` ![2]
![1]:
{{{
:info:build gcc -m64 -Wpointer-arith -Wall -Wextra -Werror -O2
-I/opt/X11/include/ -c -DX86_64 -I../boot/ta6osx -I../zlib expeditor.c
:info:build expeditor.c:846:10: fatal error: 'X11/Xlib.h' file not found
:info:build #include <X11/Xlib.h>
:info:build ^
:info:build 1 error generated.
:info:build make[2]: *** [expeditor.o] Error 1
:info:build make[2]: *** Waiting for unfinished jobs....
}}}
![2]:
{{{
:info:build gcc -dynamiclib -install_name /usr/local/lib/libz.1.dylib
-compatibility_version 1 -current_version 1.2.8 -m64 -fPIC -m64
-DHAVE_HIDDEN -o libz.1.2.8.dylib adler32.lo crc32.lo deflate.lo
infback.lo inffast.lo inflate.lo inftrees.lo trees.lo zutil.lo compress.lo
uncompr.lo gzclose.lo gzlib.lo gzread.lo gzwrite.lo -lc
}}}
--
Ticket URL: <https://trac.macports.org/ticket/51863#comment:1>
MacPorts <https://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list