[MacPorts] #51557: mp3fs build error on Leopard i366

[MacPorts]

#51557: mp3fs build error on Leopard i366
-------------------------+--------------------------------
 Reporter:  arboz@…      |      Owner:  macports-tickets@…
     Type:  defect       |     Status:  new
 Priority:  Normal       |  Milestone:
Component:  ports        |    Version:  2.3.4
 Keywords:  build error  |       Port:
-------------------------+--------------------------------
 While building new port for mp3fs
 https://trac.macports.org/changeset/149164

 The build fails with  ''unrecognized command line option "-Wno-sign-
 conversion"''


 {{{
   CXX      transcode.o
 cc1: error: unrecognized command line option "-Wno-sign-conversion"
 cc1: error: unrecognized command line option "-Wno-sign-conversion"
 cc1plus: error: unrecognized command line option "-Wno-sign-conversion"
 make[1]: *** [transcode.o] Error 1
 }}}

 apparently my compiler does not recognize this warning flag

 I changed the generated src/Makefile
 and removed that flag from WARNINGS

 thusly


 {{{
 WARNINGS = -Wall -Wextra -Wconversion
 # -Wno-sign-conversion
 }}}

 Then called install and it proceeded with warnings


 {{{
 CXX      transcode.o
 fuseops.c: In function ‘mp3fs_readdir’:
 fuseops.c:166: warning: passing argument 4 of ‘filler’ with different
 width due to prototype
 fuseops.c: In function ‘mp3fs_open’:
 fuseops.c:268: warning: cast from pointer to integer of different size
 fuseops.c: In function ‘mp3fs_read’:
 fuseops.c:308: warning: cast to pointer from integer of different size
 fuseops.c: In function ‘mp3fs_release’:
 fuseops.c:353: warning: cast to pointer from integer of different size
 }}}

 ..finished building and cleaned up.

 I am not sure, but the conversions may be safe.

 I am personally a bit fuzzy on the different compiler features
 but gcc tells me:

 {{{
 Warnings about conversions between signed and unsigned integers can be
 disabled by using -Wno-sign-conversion.
 }}}

 I haven't tested yet, but it seems good.

 I am attaching the main.log

-- 
Ticket URL: <https://trac.macports.org/ticket/51557>
MacPorts <https://www.macports.org/>
Ports system for OS X