[MacPorts] #51645: cfitsio @3.390 not setting compatibility and current version correctly

[MacPorts]

#51645: cfitsio @3.390 not setting compatibility and current version correctly
-------------------------+------------------------------
  Reporter:  aszostak@…  |      Owner:  Deil.Christoph@…
      Type:  defect      |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.3.4
Resolution:              |   Keywords:
      Port:  cfitsio     |
-------------------------+------------------------------
Changes (by ryandesign@…):

 * owner:  macports-tickets@… => Deil.Christoph@…


Old description:

> The patch-configure.diff patch is clobbering the original code in the
> configure script that sets the compatibility and current version of the
> dylib library using the -compatibility_version -current_version flags
> (https://trac.macports.org/browser/trunk/dports/science/cfitsio/files
> /patch-configure.diff?rev=148197).
> This appears to produce 3.390 shared libraries that look to MacPorts like
> they are compatible with 3.340. But this is not the case. On Linux
> systems the 3.390 shared libraries have different sonames compared to the
> 3.340 libraries.
> The net result is that binaries delivered with MacPorts that depend on
> cfitsio, are not being recompiled after an upgrade to a cfitsio version
> that has a different soname.

New description:

 The patch-configure.diff patch is clobbering the original code in the
 configure script that sets the compatibility and current version of the
 dylib library using the -compatibility_version -current_version flags
 (browser:trunk/dports/science/cfitsio/files/patch-
 configure.diff?rev=148197).
 This appears to produce 3.390 shared libraries that look to MacPorts like
 they are compatible with 3.340. But this is not the case. On Linux systems
 the 3.390 shared libraries have different sonames compared to the 3.340
 libraries.
 The net result is that binaries delivered with MacPorts that depend on
 cfitsio, are not being recompiled after an upgrade to a cfitsio version
 that has a different soname.

--

Comment:

 Agreed, the patch should not clobber the current version and compatibility
 version. The purpose of the patch was originally to add the install name,
 since upstream did not set it. Now that upstream does set install name and
 compatibility version and current version, that might no longer need to be
 patched. Once that's fixed, cfitsio's revision will need to be increased
 since this fix will change the installed files.

 Regarding other binaries linked with cfitsio's libraries needing a
 recompile: those ports should have their revisions increased after the
 above is fixed.

-- 
Ticket URL: <https://trac.macports.org/ticket/51645#comment:1>
MacPorts <https://www.macports.org/>
Ports system for OS X