[MacPorts] #44232: patch to have cmake use -dynamiclib in CMAKE_SHARED_MODULE_CREATE

[MacPorts]

#44232: patch to have cmake use -dynamiclib in CMAKE_SHARED_MODULE_CREATE
--------------------------+-------------------------
  Reporter:  rjvbertin@…  |      Owner:  michaelld@…
      Type:  enhancement  |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch
      Port:  cmake        |
--------------------------+-------------------------

Comment (by rjvbertin@…):

 Let me repeat here what I've already tried to indicate elsewhere about a
 year ago, namely that this is a "fix" that "upstreams" had apparently good
 reason to reject (http://public.kitware.com/Bug/view.php?id=15126). Even
 the related trac ticket (#40188) was closed as "wontfix" because software
 should not rely on being able to use plugins (".bundle objects") as shared
 libraries.

 In my original submission I said there were no side-effects, but IIRC I
 did run into one that made me remove the patch from my own CMake port last
 year. I cannot remember the exact details, but it most likely had to do
 with the extension used for the resulting plugins. With `-dynamiclib`
 that'd usually be `.dylib`, whereas most software originally written for
 Linux will expect (and typically hardcode) a `.so` extension.

 In practice there are only very few projects out there that have the bad
 habit of trying to use plugins as shared libraries, and all examples I've
 seen do that in auto/unittest scenarios. In all those cases the simplest
 fix has been to skip building the test(s) in question.

 I'm pretty sure I apologised for proposing this patch, let me repeat that
 here too. My apologies!

-- 
Ticket URL: <https://trac.macports.org/ticket/44232#comment:5>
MacPorts <https://www.macports.org/>
Ports system for OS X