[MacPorts] #1857: UPDATE: [mp3info] stock build shouldn't depend on libgtk

[MacPorts]

#1857: UPDATE: [mp3info] stock build shouldn't depend on libgtk
------------------------+--------------------
  Reporter:  pjenvey@…  |      Owner:  fkr@…
      Type:  defect     |     Status:  closed
  Priority:  Low        |  Milestone:
 Component:  ports      |    Version:  1.0
Resolution:  fixed      |   Keywords:
      Port:  mp3info    |
------------------------+--------------------
Changes (by ryandesign@…):

 * port:   => mp3info


Old description:

> mp3info only needs to depend on libgtk if you're building the 'gmp3info'
> or 'all' target.
>
> These targets (just 'all', actually) will only be used when building the
> x11 variant of the port. This
> variant does a
> depends_lib-append to add libgtk to the dependency list, which is
> correct.
>
> The libgtk dependency already exists, however, and it shouldn't. The port
> will build just the 'mp3info'
> target
> by default, which does not need the libgtk dependency.
>
> To make a long story short, our simple mp3info build depends on libgtk,
> but should not, unless the
> x11 variant is used.
>
> Index: Portfile
> ===============================================================
> ====
> RCS file:
> /Volumes/src/cvs/od/proj/darwinports/dports/audio/mp3info/Portfile,v
> retrieving revision 1.7
> diff -u -r1.7 Portfile
> --- Portfile    18 Jan 2004 04:23:37 -0000      1.7
> +++ Portfile    21 May 2004 21:00:47 -0000
> @@ -15,7 +15,6 @@
>  extract.suffix .tgz
>  checksums      md5 879d0ced8ede5ec9fbaff4813851ea3f
>  patchfiles     patch-Makefile
> -depends_lib     lib:libgtk.1:gtk1
>  build.target   mp3info
>  configure      { cd ${worksrcpath}
>                   reinplace
> "s|prefix=/usr/local|prefix=${destroot}${prefix}|g" Makefile }

New description:

 mp3info only needs to depend on libgtk if you're building the 'gmp3info'
 or 'all' target.

 These targets (just 'all', actually) will only be used when building the
 x11 variant of the port. This
 variant does a
 depends_lib-append to add libgtk to the dependency list, which is correct.

 The libgtk dependency already exists, however, and it shouldn't. The port
 will build just the 'mp3info'
 target
 by default, which does not need the libgtk dependency.

 To make a long story short, our simple mp3info build depends on libgtk,
 but should not, unless the
 x11 variant is used.

 {{{
 Index: Portfile
 ===================================================================
 RCS file:
 /Volumes/src/cvs/od/proj/darwinports/dports/audio/mp3info/Portfile,v
 retrieving revision 1.7
 diff -u -r1.7 Portfile
 --- Portfile    18 Jan 2004 04:23:37 -0000      1.7
 +++ Portfile    21 May 2004 21:00:47 -0000
 @@ -15,7 +15,6 @@
  extract.suffix .tgz
  checksums      md5 879d0ced8ede5ec9fbaff4813851ea3f
  patchfiles     patch-Makefile
 -depends_lib     lib:libgtk.1:gtk1
  build.target   mp3info
  configure      { cd ${worksrcpath}
                   reinplace
 "s|prefix=/usr/local|prefix=${destroot}${prefix}|g" Makefile }
 }}}

--

-- 
Ticket URL: <https://trac.macports.org/ticket/1857#comment:2>
MacPorts <https://www.macports.org/>
Ports system for OS X