[MacPorts] #7190: BUG: zabbix port is broken and makes index generation fail

[MacPorts]

#7190: BUG: zabbix port is broken and makes index generation fail
----------------------+---------------------
  Reporter:  dluke@…  |      Owner:  markd@…
      Type:  defect   |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  1.0
Resolution:  fixed    |   Keywords:
      Port:  zabbix   |
----------------------+---------------------
Changes (by ryandesign@…):

 * port:   => zabbix


Old description:

> The zabbix port attempts to add a user and add a group when portindex
> parses the file (which fails and thus causes index generation to fail).
>
> Parts of the port that actually do things (as apposed to assigning values
> to variables) need to go into one of the pre/post phases.
>
> Something like this inline patch which may or may not work and may or may
> not do the right thing would be appropriate.
>
> Index: Portfile
> ===================================================================
> RCS file:
> /Volumes/src/cvs/od/proj/darwinports/dports/net/zabbix/Portfile,v
> retrieving revision 1.2
> diff -u -r1.2 Portfile
> --- Portfile    11 Feb 2006 10:21:46 -0000      1.2
> +++ Portfile    11 Feb 2006 16:25:33 -0000
> @@ -44,8 +44,10 @@
>         startupitem.start
> "${prefix}/share/zabbix/zabbix_server.init start"
>         startupitem.stop
> "${prefix}/share/zabbix/zabbix_server.init stop"
>
> -       adduser zabbix
> -       addgroup zabbix
> +       post-extract {
> +                       adduser zabbix
> +                       addgroup zabbix
> +       }
>  }
>
>  variant agent_only {
>
> Thanks!

New description:

 The zabbix port attempts to add a user and add a group when portindex
 parses the file (which fails and thus causes index generation to fail).

 Parts of the port that actually do things (as apposed to assigning values
 to variables) need to go into one of the pre/post phases.

 Something like this inline patch which may or may not work and may or may
 not do the right thing would be appropriate.

 {{{
 Index: Portfile
 ===================================================================
 RCS file:
 /Volumes/src/cvs/od/proj/darwinports/dports/net/zabbix/Portfile,v
 retrieving revision 1.2
 diff -u -r1.2 Portfile
 --- Portfile    11 Feb 2006 10:21:46 -0000      1.2
 +++ Portfile    11 Feb 2006 16:25:33 -0000
 @@ -44,8 +44,10 @@
         startupitem.start       "${prefix}/share/zabbix/zabbix_server.init
 start"
         startupitem.stop        "${prefix}/share/zabbix/zabbix_server.init
 stop"

 -       adduser zabbix
 -       addgroup zabbix
 +       post-extract {
 +                       adduser zabbix
 +                       addgroup zabbix
 +       }
  }

  variant agent_only {
 }}}

 Thanks!

--

-- 
Ticket URL: <https://trac.macports.org/ticket/7190#comment:2>
MacPorts <https://www.macports.org/>
Ports system for OS X